Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for html5's contenteditable #182

Closed
wants to merge 1 commit into from

Conversation

phaza
Copy link

@phaza phaza commented Nov 5, 2010

Please note:
The selenium webdriver doesn't properly support clearing out contenteditable nodes, so basically set() is more like prepend than set.
Also note that I wasn't quite sure how to express in the gemspec a dependency on another git repostory(xpath), so I moved it into the Gemfile. I need the xpath repository because I had to make some changes to xpath to make it recognize contenteditable as a fillable field too. There's a pull request for that too.

Sorry about the mess, but I'm not sure how this could have been done any different. (Except simply providing patches)

@jnicklas
Copy link
Collaborator

jnicklas commented Nov 5, 2010

Not really sure how to handle the XPath stuff, it's a deficiency in bundler that the Gemfile can't override gemspec dependencies, imho. I just posted a message about this to the bundler list: http://groups.google.com/group/ruby-bundler/browse_thread/thread/d4215c4930a63ffc

BTW: it's my policy to not increase the version number until a new version is released, I just find it easier to handle this way.

Could you redo the pull request without the version number bump and the changes to the gemspec and gemfile (I'll fix that).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants