Support for html5's contenteditable #182
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note:
The selenium webdriver doesn't properly support clearing out contenteditable nodes, so basically set() is more like prepend than set.
Also note that I wasn't quite sure how to express in the gemspec a dependency on another git repostory(xpath), so I moved it into the Gemfile. I need the xpath repository because I had to make some changes to xpath to make it recognize contenteditable as a fillable field too. There's a pull request for that too.
Sorry about the mess, but I'm not sure how this could have been done any different. (Except simply providing patches)