Change #text to be closer to what a browser displays #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalpole
force-pushed
the
whitespace
branch
2 times, most recently
from
6199a1e
to
60df000
Compare
peetar
reviewed
Jan 9, 2019
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| it "should find the ancestor element using the given locator and options" do | |||
| el = @session.find(:css, '#child') | |||
| expect(el.ancestor('//div', text: 'Ancestor Ancestor Ancestor')[:id]).to eq('ancestor3') | |||
| expect(el.ancestor('//div', text: "Ancestor\nAncestor\nAncestor")[:id]).to eq('ancestor3') | |||
There was a problem hiding this comment.
After upgrading our gems, we ended up with a few hundred test failures requiring an update like this. (Yes, we foolishly assumed the whitespace normalization would never change and used this pattern all over our test suite). Anybody have a suggestion on how we might solve this without having to manually update a whole bunch of assertions?
There was a problem hiding this comment.
@peetar You can use Capybara.default_normalize_ws = true - although that will most likely go away in Capybara 4 - so you're going to want to update your tests to check what a user actually sees at some point.
There was a problem hiding this comment.
Thanks for the suggestion, might use it as a temporary workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Playing with potential changes for Issue #1353