New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make :respect_data_method default to true with capybara/rails #793

Merged
merged 1 commit into from Aug 30, 2012

Conversation

Projects
None yet
5 participants
@joliss
Collaborator

joliss commented Aug 21, 2012

I'm writing an upgrade guide, and I find myself telling people "Capybara 2.0 will break your test suite. To stop it from breaking your test suite, enable :respect_data_method." This is something that we'll basically have to tell all users, or they'll get tripped up.

Instead, I'd suggest that we enable the right behavior by default, whenever capybara/rails is required.

Ignoring data-method in the RackTest driver is very reasonable when we're not testing Rails apps, for what it's worth. But in Rails apps, people will generally want to honor data-method.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 21, 2012

This pull request fails (merged 8eb4245 into 6529da7).

travisbot commented Aug 21, 2012

This pull request fails (merged 8eb4245 into 6529da7).

@joliss

This comment has been minimized.

Show comment
Hide comment
@joliss

joliss Aug 21, 2012

Collaborator

The alternative of course is adding js: true to tests that require data-method, but that makes the tests much slower, and you'll likely have to take care of confirm boxes.

Collaborator

joliss commented Aug 21, 2012

The alternative of course is adding js: true to tests that require data-method, but that makes the tests much slower, and you'll likely have to take care of confirm boxes.

@colszowka

This comment has been minimized.

Show comment
Hide comment
@colszowka

colszowka Aug 23, 2012

1️⃣

I think a lot of people will get bad headaches when they bump into this unexpected behavior.

colszowka commented Aug 23, 2012

1️⃣

I think a lot of people will get bad headaches when they bump into this unexpected behavior.

jnicklas added a commit that referenced this pull request Aug 30, 2012

Merge pull request #793 from joliss/respect-data-method
Make :respect_data_method default to true with capybara/rails

@jnicklas jnicklas merged commit 14411d4 into teamcapybara:master Aug 30, 2012

1 check failed

default The Travis build failed
Details
@jnicklas

This comment has been minimized.

Show comment
Hide comment
@jnicklas

jnicklas Aug 30, 2012

Collaborator

Alright. Let's do it this way.

Collaborator

jnicklas commented Aug 30, 2012

Alright. Let's do it this way.

@colszowka

This comment has been minimized.

Show comment
Hide comment
@colszowka

colszowka Aug 30, 2012

Cool, thanks :)

colszowka commented Aug 30, 2012

Cool, thanks :)

@joliss

This comment has been minimized.

Show comment
Hide comment
@joliss

joliss Aug 30, 2012

Collaborator

Awesome, thanks for merging!

Collaborator

joliss commented Aug 30, 2012

Awesome, thanks for merging!

carlosantoniodasilva referenced this pull request Feb 26, 2013

Move the RackTest driver override to capybara/rails
This change enables the `:respect_data_method` option from the RackTest
driver for Rails projects that don't use RSpec.
@filipegiusti

This comment has been minimized.

Show comment
Hide comment
@filipegiusti

filipegiusti Apr 4, 2013

Why this is the default?

filipegiusti commented on 8eb4245 Apr 4, 2013

Why this is the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment