New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's eat our own dogfood #577
Comments
@davvd valid bug |
@krzyk how would you configure exclusions for such run? |
@mkordas if they are required (shouldn't, if we add new check we should fix problems that it causes in qulice using e.g. puzzles) it reads excludes from the pom.xml files (and from the code). |
@krzyk thanks for the ticket, your account was topped for 30 mins, payment 73942602 |
@davvd this is postponed |
@mkordas I've updated the description, would you like to work on this? |
@krzyk first we need to update Qulice to 0.15.4 for our code, there are many violations. Should I raise issue for that? |
@mkordas I don't think we need to upgrade for this issue specifically, this will be just a build informing us of the violations. |
@krzyk OK, I'll submit an issue with some proposals how to fix missing since tag. So you propose to allow failing Travis build for some time and red mark on each commit? |
@mkordas we won't be able to always have a green build, e.g. when we add a code that reverses the previous check In the future if the newly added rule is not conflicting with previous qulice, we will fix the code during the implementation of the check (or add a todo if it is more work). |
@mkordas are you interested? |
@mkordas ping |
@mkordas yes, he is a pain, I'm just asking if I should look for someone else :) |
@krzyk I'll give a try :) |
* added new build to execute freshly built Qulice over entire code * due to Travis YML syntax limitations two different commands must be specified by environmental variables
For yegor256#577: * added new build to execute freshly built Qulice over entire code * due to Travis YML syntax limitations two different commands must be specified by environmental variables
For yegor256#577: * added new build to execute freshly built Qulice over entire code * due to Travis YML syntax limitations two different commands must be specified by environmental variables
For yegor256#577: * added new build to execute freshly built Qulice over entire code * due to Travis YML syntax limitations two different commands must be specified by environmental variables
For yegor256#577: * added new build to execute freshly built Qulice over entire code * due to Travis YML syntax limitations two different commands must be specified by environmental variables
For yegor256#577: * added new build to execute freshly built Qulice over entire code * due to Travis YML syntax limitations two different commands must be specified by environmental variables
For yegor256#577: * added new build to execute freshly built Qulice over entire code * due to Travis YML syntax limitations two different commands must be specified by environmental variables
@krzyk please assign me here |
@davvd this is not postponed |
@mkordas does the task appear in your agenda? I don't see you assigned in github, but David confirmed it. |
@krzyk yes, I see it. Can you close the issue? |
@mkordas thanks |
@davvd this is not postponed |
Before merging each code we should run newly built qulice against qulice codebase.
This will allow us to catch errors in our checks earlier.
We should have another travis build (only travis) that will do the validations using newly built plugin - it is because sometimes we introduce incompatible changes that could fail on our current codebase, but we can't updated it because it will fail on the previous qulice plugin.
So we should have a build that will be just an information for us, what new violations are being detected. This should allow us to fix invalid ones.
Options how to do it:
1.
mvn clean install
mvn com.qulice:qulice-maven-plugin:1.0-SNAPSHOT:check -Pqulice
(here we will probably need to add excludes e.g.-Dqulice.excludes="xml:.*,checkstyle:.*,pmd:.*/src/test/resources/.*"
)<properties>
tag)mvn clean install
mvn versions:set "-DnewVersion=1.1"
mvn clean install -Pqulice -Dqulice.version=1.0-SNAPSHOT
For the 1 and 2, we should also make sure that we run the build for all the modules, so some shell magic will be needed to enter each directory and build given plugin.
The text was updated successfully, but these errors were encountered: