Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit non-final classes #920

Closed
driver733 opened this issue Aug 3, 2018 · 32 comments
Closed

Prohibit non-final classes #920

driver733 opened this issue Aug 3, 2018 · 32 comments

Comments

@driver733
Copy link

@driver733 driver733 commented Aug 3, 2018

Let's create a new Checkstyle rule that will enforce the usage of final keyword in all classes. (Prohibit non-final classes)

@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 3, 2018

@krzyk/z please, pay attention to this issue

@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 3, 2018

@driver733/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@krzyk
Copy link
Collaborator

@krzyk krzyk commented Aug 4, 2018

@driver733 there is already such rule, or similar: it prohibits a method in class that is not final.

@driver733
Copy link
Author

@driver733 driver733 commented Aug 4, 2018

@krzyk This is not enough. The rule you mentioned does not prohibit making class extensible (non-final).

@krzyk
Copy link
Collaborator

@krzyk krzyk commented Aug 13, 2018

@0crat in

@krzyk
Copy link
Collaborator

@krzyk krzyk commented Aug 13, 2018

@0crat help

@0crat 0crat added the scope label Aug 13, 2018
@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 13, 2018

@0crat in (here)

@krzyk Job #920 is now in scope, role is DEV

@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 13, 2018

@0crat help (here)

@krzyk Can't understand "help", try one of these:

  • assign Assign a performer to this issue
  • boost Set a boost for the job
  • continue Remove a job's impediment
  • hello Just say hello
  • in Register this issue in scope (WBS)
  • out Close the order and remove this job from scope
  • pay Pay a user some extra cash
  • quality Review a task
  • resign Resign from this issue
  • status Check the status of the job
  • version Print current version of the bot
  • wait Register an impediment for a job

@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 13, 2018

Bug was reported, see §29: +15 point(s) just awarded to @driver733/z

@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 13, 2018

@krzyk/z everybody who has role DEV is banned at #920; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 18, 2018

@krzyk/z everybody who has role DEV is banned at #920; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 23, 2018

@krzyk/z everybody who has role DEV is banned at #920; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 28, 2018

@krzyk/z everybody who has role DEV is banned at #920; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

@0crat 0crat commented Sep 2, 2018

@krzyk/z everybody who has role DEV is banned at #920; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

@0crat 0crat commented Sep 7, 2018

@krzyk/z everybody who has role DEV is banned at #920; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

@0crat 0crat commented Sep 12, 2018

@krzyk/z everybody who has role DEV is banned at #920; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

@0crat 0crat commented Sep 17, 2018

@krzyk/z everybody who has role DEV is banned at #920; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented Jan 24, 2019

@driver733 the puzzle #1007 is still not solved.

@paulodamaso
Copy link
Contributor

@paulodamaso paulodamaso commented Jan 24, 2019

@driver733 Merged in #994 please close

@paulodamaso
Copy link
Contributor

@paulodamaso paulodamaso commented Jan 27, 2019

@driver733 ping

@paulodamaso
Copy link
Contributor

@paulodamaso paulodamaso commented Feb 1, 2019

@krzyk looks like @driver733 is absent, please close

@krzyk
Copy link
Collaborator

@krzyk krzyk commented Feb 1, 2019

@paulodamaso I don't have any permissions in this repo :(, I can't close, create labels etc.

@paulodamaso
Copy link
Contributor

@paulodamaso paulodamaso commented Feb 1, 2019

@krzyk Who could help us then? This task is solved and it is in my agenda preventing from receiving more tasks

@krzyk
Copy link
Collaborator

@krzyk krzyk commented Feb 1, 2019

@yegor256 could you close (authors are not responding):

  • #920 (finished here)
  • #870 (no longer valid)
  • #866 (no longer valid)
  • #868 (no longer valid)

@driver733 driver733 closed this Feb 1, 2019
@0crat
Copy link
Collaborator

@0crat 0crat commented Feb 1, 2019

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Feb 1, 2019
@0crat
Copy link
Collaborator

@0crat 0crat commented Feb 1, 2019

The job #920 is now out of scope

@ypshenychka
Copy link

@ypshenychka ypshenychka commented Feb 2, 2019

@0crat quality good

@0crat
Copy link
Collaborator

@0crat 0crat commented Feb 2, 2019

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

@0crat 0crat commented Feb 2, 2019

Order was finished, quality is "good": +35 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

@0crat 0crat commented Feb 2, 2019

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented Feb 7, 2019

@driver733 the only puzzle #1007 is solved here.

@yegor256
Copy link
Member

@yegor256 yegor256 commented May 5, 2019

@krzyk I made you a collaborator in this repo, you can now manage issues yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants