New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes #77

Merged
merged 5 commits into from Jan 5, 2016

Conversation

Projects
None yet
2 participants
@jonathanpike
Copy link
Contributor

jonathanpike commented Jan 1, 2016

More bug and issue fixes:

  1. Per #68, I added before_action filters for both games currently in progress and games not yet started. For games currently in progress, only the players can see the show page. No user is allowed to see the show page of a game not yet started.
  2. Per #73, I've fixed the issue with the jumbotron issue not showing in production.
  3. I fixed a small bug that caused a big issue. In #71, I removed the height styling from the pieces because it pushed them up too far. Little did I know that doing so also removed the drop targets on the board. I've fixed that here.
  4. I also removed some unused actions (edit, destroy) from games_controller.

ronny2205 added a commit that referenced this pull request Jan 5, 2016

@ronny2205 ronny2205 merged commit f611434 into master Jan 5, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ronny2205

This comment has been minimized.

Copy link
Contributor

ronny2205 commented Jan 5, 2016

Just checked and merged. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment