Skip to content
Permalink
Browse files

fix(controller): Revert check_image_access only when using docker

This reverts commit b3a741d.
  • Loading branch information
Cryptophobia committed Jun 14, 2019
1 parent 964e64a commit 1114ea5e628e9f15e7e3e58dc79692fd29182772
Showing with 3 additions and 4 deletions.
  1. +3 −4 rootfs/api/models/app.py
@@ -520,15 +520,14 @@ def deploy(self, release, force_deploy=False, rollback_on_failure=True): # noqa
image = settings.SLUGRUNNER_IMAGE if release.build.type == 'buildpack' else release.image

try:
# check access to the image, so users can't exploit the k8s image cache
# to gain access to other users' images
release.check_image_access()
# create the application config in k8s (secret in this case) for all deploy objects
self.set_application_config(release)
# only buildpack apps need access to object storage
# only docker apps need check access to the image, so users can't exploit the k8s
# image cache to gain access to other users' images
if release.build.type == 'buildpack':
self.create_object_store_secret()
else:
release.check_image_access()

# gather all proc types to be deployed
tasks = [

0 comments on commit 1114ea5

Please sign in to comment.
You can’t perform that action at this time.