This repository has been archived by the owner on Nov 27, 2020. It is now read-only.
implement driver#window_size and driver#resize_window_to from capybara #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalpole
added a commit
that referenced
this pull request
Oct 1, 2015
implement driver#window_size and driver#resize_window_to from capybara
|
Just in case: I remember some problems with window resizing... not sure and usually we add an entry to CHANGELOG. Thanks for your great work! |
|
Ok, I had added a test for resizing (it fails capybaras because they rely on window.outerWidth/Height which phantomjs doesn't provide) so it does appear to work. If you remember any more details on the problems let me know. I'll add to the change log later today |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements 2 missing methods from driver -- I think the only missing capybara driver method for windows now is maximize_window, which doesn't really make sense in poltergeist