Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Parser cannot handle tests run with t.Parallel() #5
When running tests in parallel, the test result may not immediately follow the RUN line:
I may try and fix this in my fork and send you a patch.
I guess the question would be - if we can't reliably determine the correct test for any given output, would it be better to fail to interpret the results entirely, or to throw away the ambiguous information?
We could track the number of in-flight tests unambiguously based on the start/stop messages, and for the unambiguous cases, just put it in there. Iff there's any ambiguity, we can mark those tests as ambiguous, emit a line to the console explaining the issue, and potentially replace the output from the test with a marker string of some sort so that the test maintainer can solve the issue.
I'd argue that the output capture is less important than the correct interpretation of the test results in a lot of the use-cases that require you to convert to xunit output?
I'm a firm believer in the "fail fast" methodology and not doing GIGO.
Since what the user will see is only the Jenkins web page with the results - they'll have no idea if some of the tests we ignored.
Can you elaborate? I don't think there's a bullet proof unambiguous cases.
I don't follow. If "correct interpretation" is what's important - than there's nothing we can do (IMO).
Maybe there users can provide a command line option to