Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase initial conference list from 150 to 600 #430

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@cgrail
Copy link
Member

cgrail commented Mar 1, 2019

I would like to increase the amount of conferences which are initially loaded from 150 to 600. Currently you can just see conferences for the next 2 months. The load more button is also not very large and the page doesn't load more conferences when you hit the bottom of the page.

I think increasing the initial load would be an acceptable quick fix. The payload from Algolia would be about 100KB (currently the payload is about 25KB). That shouldn't impact the performance too much. Most of the content Algolia sends is nevertheless not used.

@cgrail

This comment has been minimized.

Copy link
Member Author

cgrail commented Mar 1, 2019

@nimzco @prigara what do you think?

@nimzco

This comment has been minimized.

Copy link
Member

nimzco commented Mar 2, 2019

It should be fine, my only worry is for google crawlers. I don’t know how much they wait for JS to load.
But we can try, if I see google trafic going down will change that :)

@nimzco

This comment has been minimized.

Copy link
Member

nimzco commented Mar 2, 2019

Actually, thinking about it more, it would still increase the load time by 4 (thinking about slow connexions / 3G). I think we should rather implement an auto load or stylé the button to be more visible.

@cgrail

This comment has been minimized.

Copy link
Member Author

cgrail commented Mar 4, 2019

I'm fine with either solution. I've also optimised the Algolia search result and it now only includes the properties which are displayed on the website. The load time wouldn't increase by 4. The page currently loads ~284KB. The Algolia query results is 17KB large. The optimised JSON with all conferences is now 56KB large. So instead of 5% of the loaded resources it would be 19%. At least for a cold cache. The size of the json could be reduced by another 1/3 by removing the _highlightResult property. But I don't know if that's possible and how that would impact the real load times.

screenshot 2019-03-04 at 17 46 33

@nimzco

This comment has been minimized.

Copy link
Member

nimzco commented Mar 6, 2019

Oh I see. Thanks for the details Christian!
Let’s move forward with that then 👍🏼

@nimzco

nimzco approved these changes Mar 6, 2019

@cgrail cgrail merged commit 335db83 into master Mar 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cgrail cgrail deleted the IncreaseInitialHitsPerpage branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.