Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis auto-tests are broken #373

Closed
cnuernber opened this issue Sep 30, 2023 · 5 comments
Closed

Travis auto-tests are broken #373

cnuernber opened this issue Sep 30, 2023 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cnuernber
Copy link
Collaborator

I honestly don't have the patience to deal with this right now. Open to fixing travis or switching to github actions - either works for me.
@cnuernber cnuernber added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 30, 2023
@iperdomo
Copy link
Contributor

iperdomo commented Oct 4, 2023

Hi @cnuernber I would like to offer help with this issue.

I'm familiar with GH actions, not so much with deps.edn - old lein user here -. Reading the TravisCI definition, the build process seems straight forward. Download some sample dataset and execute some tests via clj.

As first step we should port the TravisCI definition to GH actions. Then we can discuss if we can improve it, e.g. different JDKs and versions.

@cnuernber
Copy link
Collaborator Author

That sounds perfect to me. The one snag here is probably going to be mkl and we will need to test when it is possible and avoid when it is not. The mac-m1 alias does exactly this.

If you are up for it we would certainly appreciate it.

@iperdomo
Copy link
Contributor

iperdomo commented Oct 5, 2023

I've done some testing locally in an Ubuntu 22.04 VM with openjdk-8, openjdk-11, and openjdk-17 and tests are passing. I'll start working in a fork and open a draft PR when I think is ready for initial review.

cnuernber pushed a commit that referenced this issue Oct 6, 2023
@iperdomo
Enable automated tests using GitHub Actions (#374)
94a6f4d 
* [#373] Disable TravisCI, enable GitHub Actions - WIP

* [#373] Trigger build

* [#373] Missing `runs-on` property

* [#373] `clj` is for interactive development - requires `rlwrap`

> `clj` and `clojure` differ in that `clj` has extra support for use
> as a REPL in a terminal, and should be preferred unless you don’t want
> that support, then use clojure.

https://clojure.org/reference/deps_and_cli

* [#373] Enable dependency caching

* [#373] Restore cached dependencies if present
@iperdomo
Copy link
Contributor

iperdomo commented Oct 6, 2023

I'll give it a second look at the workflow and see how we can have a build matrix, different JDK versions and potentially architecture

cnuernber pushed a commit that referenced this issue Oct 9, 2023
@iperdomo
Run automated tests with different JDK versions (#378)
58dcb88 
* [#373] Enable run tests with different JDK versions

* [#373] Enable testing with with JDK 8,11,17

* [#373] Fix typo - missing `$`
@cnuernber
Copy link
Collaborator Author

Thoroughly fixed :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cnuernber @iperdomo