Skip to content

squid:S00115 - Constant names should comply with a naming convention #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

squid:S00115 - Constant names should comply with a naming convention #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/uk/co/techblue/alfresco/dto/common/GroupSorter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
public enum GroupSorter {

/** The authority name. */
authorityName,
AUTHORITY_NAME,

/** The short name. */
shortName,
SHORT_NAME,

/** The display name. */
displayName
DISPLAY_NAME
}
26 changes: 13 additions & 13 deletions src/main/java/uk/co/techblue/alfresco/dto/common/UserRole.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@
public enum UserRole {

/** The Owner. */
Owner,
/** The Coordinator. */
Coordinator,
/** The Collaborator. */
Collaborator,
/** The Contributor. */
Contributor,
/** The Editor. */
Editor,
/** The Consumer. */
Consumer,
/** The All. */
All
OWNER,
/** The Coordinator. */
COORDINATOR,
/** The Collaborator. */
COLLABORATOR,
/** The Contributor. */
CONTRIBUTOR,
/** The Editor. */
EDITOR,
/** The Consumer. */
CONSUMER,
/** The All. */
ALL
}
4 changes: 2 additions & 2 deletions src/test/java/uk/co/techblue/alfresco/client/test/AlfrescoServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ private static void testGetParentAuthorities() {
final GroupService userService = new GroupService(BASE_URL, AUTH_TICKET);
try {
final AuthorityQuery authorityQuery = new AuthorityQuery();
authorityQuery.setSortBy(GroupSorter.authorityName);
authorityQuery.setSortBy(GroupSorter.AUTHORITY_NAME);
System.out.println(userService.getParentAuthorities(
"EMAIL_CONTRIBUTORS", authorityQuery));
} catch (final GroupException e) {
Expand All @@ -201,7 +201,7 @@ private static void testGetChildAuthorities() {
final GroupService userService = new GroupService(BASE_URL, AUTH_TICKET);
try {
final AuthorityQuery authorityQuery = new AuthorityQuery();
authorityQuery.setSortBy(GroupSorter.authorityName);
authorityQuery.setSortBy(GroupSorter.AUTHORITY_NAME);
System.out.println(userService.getChildAuthorities(
"ALFRESCO_ADMINISTRATORS", authorityQuery));
} catch (final GroupException e) {
Expand Down