Make reportr change the URL when selecting an interval #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s shareable/reloadable. This commit modifies reportr so that all controllers update the URL when changing an interval in the report. This allows sharing specific reports via the URL. Also developers can easily reload reports without having to select the interval again every time. I also switched the require.js injection to relative paths (saves some screenspace and even bytes) and the AngularJS injection to work via the .$inject property which is also great for saving some screenspace and still works with minification.
FrontierPsychiatrist
force-pushed
the
trackr-reportr-save-timespan
branch
from
5fa2bfd
to
e683876
Compare
alexgutjahr
pushed a commit
that referenced
this pull request
May 20, 2015
…espan Make reportr change the URL when selecting an interval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies reportr so that all controllers update the URL when changing an interval in the report. This allows sharing specific reports via the URL. Also developers can easily reload reports without having to select the interval again every time.
I also switched the require.js injection to relative paths (saves some screenspace and even bytes) and the AngularJS injection to work via the .$inject property which is also great for saving some screenspace and still works with minification.