Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impossible to use additional vendor dirs with relative path #1

Closed
ktruehl opened this issue Aug 23, 2019 · 1 comment
Closed

impossible to use additional vendor dirs with relative path #1

ktruehl opened this issue Aug 23, 2019 · 1 comment
Assignees
Labels
bug
Projects

Comments

@ktruehl
Copy link

@ktruehl ktruehl commented Aug 23, 2019

Hi!

Once I upgrade to 3.7.1 loading my custom modules didn't work any more. The import complained that it couldn't find the service.xml file any more. This is how I defined the additional vendor dirs in my custom techdivision-import.json:

  "additional-vendor-dirs": [
    {
      "vendor-dir": "app/code",
      "libraries": [
        "Client/PimCategoriesImport"
      ]
    }
  ],

Since we have a number of setups and the placement of the app/code directory is not always the same depending on the setup, I cannot specifiy an absolute directory for vendor-dir.

The problem is that when the XmlFileLoader is created in TechDivision\Import\Cli\Configuration\LibraryLoader on line 102

$customLoader = new XmlFileLoader($this->getContainer(), new FileLocator());

no path array is given to the FileLocator constructor. So necessarily all additional vendor dirs must be absolute.

At least the FileLocator should get the current working directory as path like this:

$customLoader = new XmlFileLoader($this->getContainer(), new FileLocator([getcwd()]));

Best and thanks,
Klaas

@wagnert wagnert self-assigned this Aug 24, 2019
@wagnert wagnert added the bug label Aug 24, 2019
@wagnert wagnert added this to In Progress in M2IF Sep 2, 2019
@wagnert wagnert closed this in 01a2011 Sep 2, 2019
@wagnert wagnert moved this from In Progress to Testing in M2IF Sep 2, 2019
wagnert added a commit to techdivision/import-cli-simple that referenced this issue Sep 2, 2019
- Fixed techdivision/import-category-ee#34
- Add cache warmer for product varchar values to improve performance on CSV files with missing url_key value
@wagnert

This comment has been minimized.

Copy link
Member

@wagnert wagnert commented Sep 2, 2019

@ktruehl Has been fixed with version 3.7.3. We've refactored the functionality to behave as like before version 3.6.* which was the version you used before, I assumed.

@wagnert wagnert moved this from Testing to Done in M2IF Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
M2IF
Done
2 participants
You can’t perform that action at this time.