Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added retry checking into do_get in the api. A 'retry' (429) will be… #5

Closed
wants to merge 1 commit into from
Closed

Added retry checking into do_get in the api. A 'retry' (429) will be… #5

wants to merge 1 commit into from

Conversation

zpeters
Copy link
Contributor

@zpeters zpeters commented Oct 6, 2018

… returned as an 'ok' status. We will sleep for the specified time and retry thequery transparently

@zpeters
Added retry checking into do_get in the api. A 'retry' (429) will be …
e5c11b6 
…returned as an 'ok' status. We will sleep for the specified time and retry thequery transparently
@zpeters zpeters mentioned this pull request Oct 6, 2018
Open
techgaun
techgaun requested changes Oct 6, 2018
View reviewed changes
Copy link
Owner

@techgaun techgaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zpeters very useful change but this will now raise for error tuples. could you add a case for error tuples handling.

lib/ex_pwned/api.ex Show resolved Hide resolved
@zpeters zpeters closed this Oct 6, 2018
@zpeters
Copy link
Contributor Author

zpeters commented Oct 6, 2018

Withdrawn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techgaun techgaun techgaun requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zpeters @techgaun