Skip to content

Added support of room_id option #3

Merged
merged 1 commit into from Mar 16, 2013

2 participants

@kirs
Collaborator
kirs commented Sep 26, 2012

Instead of room option, you can pass the room_id if your room name contains some special characters.

@technicalpickles
Owner

Sorry for slow response, maintaining open source is hard 😓

This looks like a good addition. Off hand, do you have any examples of said special cases? I'd also like to see some updated docs to specify room_id and specs to confirm it working.

I added support for multiple rooms awhile back, so this isn't going to merge cleanly anymore.

@technicalpickles technicalpickles commented on an outdated diff Dec 9, 2012
lib/capistrano/campfire.rb
campfire = ::Tinder::Campfire.new account,
:token => token,
:ssl => ssl,
:ssl_verify => ssl_verify
- campfire.find_room_by_name(room_name)
+ if room_name
+ campfire.find_room_by_name(room_name)
+ else
@technicalpickles
Owner

Now that you can specify by room_name or room_id, should make this elsif room_id, with an else clause that raises an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@kirs
Collaborator
kirs commented Dec 9, 2012

@technicalpickles for example room name can be in russian or in chinese and it would be not so clear to find_room_by_name("название моей комнаты")

@technicalpickles
Owner

Makes sense. That may be an upstream bug for tinder and/or Campfire too, since that should just work.

@kirs
Collaborator
kirs commented Dec 9, 2012
@technicalpickles
Owner

@kirs gah, sorry again :( I added you as a collaborator if you'd like to merge. If you want to send the email on your rubygems account, I can add you for pushing releases.

@kirs
Collaborator
kirs commented Mar 14, 2013

Thanks! Here is my rubygems account: https://rubygems.org/profiles/Kirs

@technicalpickles
Owner

Added, thanks!

@kirs kirs merged commit 2164f2b into technicalpickles:master Mar 16, 2013
@kirs kirs deleted the kirs:room-id-support branch Mar 16, 2013
@kirs
Collaborator
kirs commented Mar 16, 2013

@technicalpickles BTW, why do we need capistrano-tinder.gemspec in this repo?

@technicalpickles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.