Skip to content
This repository has been archived by the owner. It is now read-only.

Improving row pin configuration flexbility. #23

Merged
merged 1 commit into from Feb 6, 2015
Merged

Improving row pin configuration flexbility. #23

merged 1 commit into from Feb 6, 2015

Conversation

@cy384
Copy link
Contributor

@cy384 cy384 commented Feb 6, 2015

When I was wiring up my atreus, I decided to use whatever pins were physically convenient. However, the firmware previously assumed all row pins were on PORTD, and I had one row pin on PORTC. This patch makes it easier to reconfigure pin settings for rows. As-is, it should be functionally identical if you wired as per the instructions; I'd appreciate if you could test it.

As a bonus feature, with this change the firmware doesn't clobber other pins while activating rows. This should facilitate use of any extra pins (I plan to use one for toggling LED backlighting on my board).

technomancy added a commit that referenced this pull request Feb 6, 2015
Improving row pin configuration flexbility.
@technomancy technomancy merged commit f51fc0d into technomancy:master Feb 6, 2015
@technomancy
Copy link
Owner

@technomancy technomancy commented Feb 6, 2015

Very nice; thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants