New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving row pin configuration flexbility. #23

Merged
merged 1 commit into from Feb 6, 2015

Conversation

Projects
None yet
2 participants
@cy384
Contributor

cy384 commented Feb 6, 2015

When I was wiring up my atreus, I decided to use whatever pins were physically convenient. However, the firmware previously assumed all row pins were on PORTD, and I had one row pin on PORTC. This patch makes it easier to reconfigure pin settings for rows. As-is, it should be functionally identical if you wired as per the instructions; I'd appreciate if you could test it.

As a bonus feature, with this change the firmware doesn't clobber other pins while activating rows. This should facilitate use of any extra pins (I plan to use one for toggling LED backlighting on my board).

technomancy added a commit that referenced this pull request Feb 6, 2015

Merge pull request #23 from cy384/master
Improving row pin configuration flexbility.

@technomancy technomancy merged commit f51fc0d into technomancy:master Feb 6, 2015

@technomancy

This comment has been minimized.

Owner

technomancy commented Feb 6, 2015

Very nice; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment