put pretty function code into a hook function #85

Merged
merged 4 commits into from Sep 5, 2011

Projects

None yet

2 participants

@stesla
stesla commented Jul 27, 2011

I don't like the unicode replacements, and it feels cleaner to remove a function from a hook than to remove a font-lock keyword.

There is probably a good deal more duplication removal that could be done here, as the setups are essentially identical.

stesla added some commits Jul 27, 2011
@stesla stesla put pretty function code into a hook function
I don't like the unicode replacements, and it feels cleaner to remove a function from a hook than to remove a font-lock keyword.

There is probably a good deal more duplication removal that could be done here, as the setups are essentially identical.
f0c1316
@stesla stesla remove duplication in javascript initialization 28f9464
@stesla stesla add js-mode to esk-space-for-delimiter? b7bce7b
@stesla
stesla commented Aug 25, 2011

I finished the extraction of the duplication, and also added a fix for some broken paredit behavior in js-mode.

@technomancy technomancy merged commit 6ae4749 into technomancy:master Sep 5, 2011
@technomancy
Owner

Thanks! Could you also submit this as a patch to the v2 branch?

@stesla
stesla commented Sep 8, 2011

I'd love to submit this to the v2 branch. What is the recommended way of developing/testing against the v2 branch, since it's now designed to be a package?

@technomancy
Owner

You should be able to just use M-x package-install-file to test changes to starter-kit-js provided you have the main starter-kit package installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment