Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

(eshell-gather-process-output): Revert previous change. (re-opens Bug…

…#1388)
  • Loading branch information...
commit 1bd0c45acd72d923b9aa79f583e7604263459aba 1 parent abe7f85
gm authored jwiegley committed
Showing with 5 additions and 21 deletions.
  1. +5 −21 esh-proc.el
View
26 esh-proc.el
@@ -250,27 +250,11 @@ Used only on systems which do not support async subprocesses.")
(cond
((fboundp 'start-process)
(setq proc
- ;; Bug#1388. Some commands (eg bc) check isatty to decide
- ;; whether they are being called interactively.
- ;; A normal shell pipeline has:
- ;; first: stdin tty , stdout pipe
- ;; rest : stdin pipe, stdout pipe
- ;; last : stdin pipe, stdout tty
- ;; We have:
- ;; first: stdin tty , stdout tty
- ;; last : stdin pipe, stdout pipe
- ;; In other words, the first and last elements have the
- ;; wrong kind of stdout. (Perhaps this does not matter much...)
- ;; FIXME which is better for the first element:
- ;; tty/tty (as now), or pipe/pipe?
- (let ((process-connection-type
- (unless (and eshell-in-pipeline-p
- (not (eq eshell-in-pipeline-p 'first)))
- process-connection-type)))
- (apply 'start-process
- (file-name-nondirectory command) nil
- ;; `start-process' can't deal with relative filenames
- (append (list (expand-file-name command)) args))))
+ (apply 'start-process
+ (file-name-nondirectory command) nil
+ ;; `start-process' can't deal with relative
+ ;; filenames
+ (append (list (expand-file-name command)) args)))
(eshell-record-process-object proc)
(set-process-buffer proc (current-buffer))
(if (eshell-interactive-output-p)
Please sign in to comment.
Something went wrong with that request. Please try again.