Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

(eshell-gather-process-output): Revert previous change. (re-opens Bug…

…#1388)
  • Loading branch information...
commit 1bd0c45acd72d923b9aa79f583e7604263459aba 1 parent abe7f85
gm authored jwiegley committed

Showing 1 changed file with 5 additions and 21 deletions. Show diff stats Hide diff stats

  1. +5 21 esh-proc.el
26 esh-proc.el
@@ -250,27 +250,11 @@ Used only on systems which do not support async subprocesses.")
250 250 (cond
251 251 ((fboundp 'start-process)
252 252 (setq proc
253   - ;; Bug#1388. Some commands (eg bc) check isatty to decide
254   - ;; whether they are being called interactively.
255   - ;; A normal shell pipeline has:
256   - ;; first: stdin tty , stdout pipe
257   - ;; rest : stdin pipe, stdout pipe
258   - ;; last : stdin pipe, stdout tty
259   - ;; We have:
260   - ;; first: stdin tty , stdout tty
261   - ;; last : stdin pipe, stdout pipe
262   - ;; In other words, the first and last elements have the
263   - ;; wrong kind of stdout. (Perhaps this does not matter much...)
264   - ;; FIXME which is better for the first element:
265   - ;; tty/tty (as now), or pipe/pipe?
266   - (let ((process-connection-type
267   - (unless (and eshell-in-pipeline-p
268   - (not (eq eshell-in-pipeline-p 'first)))
269   - process-connection-type)))
270   - (apply 'start-process
271   - (file-name-nondirectory command) nil
272   - ;; `start-process' can't deal with relative filenames
273   - (append (list (expand-file-name command)) args))))
  253 + (apply 'start-process
  254 + (file-name-nondirectory command) nil
  255 + ;; `start-process' can't deal with relative
  256 + ;; filenames
  257 + (append (list (expand-file-name command)) args)))
274 258 (eshell-record-process-object proc)
275 259 (set-process-buffer proc (current-buffer))
276 260 (if (eshell-interactive-output-p)

0 comments on commit 1bd0c45

Please sign in to comment.
Something went wrong with that request. Please try again.