Permalink
Browse files

Avoid grep functions.

  • Loading branch information...
technomancy committed Oct 10, 2011
1 parent 4de1159 commit 38e5fbfaa11d409be855e920c1352e41ce2e0ee6
Showing with 1 addition and 1 deletion.
  1. +1 −1 ido-ubiquitous.el
View
@@ -69,7 +69,7 @@
:group 'ido-ubiquitous)
;;;###autoload
(defcustom ido-ubiquitous-exceptions '()
(defcustom ido-ubiquitous-exceptions '(grep-read-files)
"List of commands that should not be affected by `ido-ubiquitous'.
Even when `ido-ubiquitous' mode is enabled, these commands will

2 comments on commit 38e5fbf

@DarwinAwardWinner

This comment has been minimized.

Show comment
Hide comment
@DarwinAwardWinner

DarwinAwardWinner Oct 10, 2011

Collaborator

This actually won't work. The docstring specifically says "commands", not functions. I have another branch where I'm testing a custom variable that you can add any function to: https://github.com/DarwinAwardWinner/ido-ubiquitous/commits/func-except. It seems to be working, and I'll be submitting a pull request soon after some more testing.

In the meantime, the proper solution is (disable-ido-ubiquitous-in grep-read-files).

Collaborator

DarwinAwardWinner replied Oct 10, 2011

This actually won't work. The docstring specifically says "commands", not functions. I have another branch where I'm testing a custom variable that you can add any function to: https://github.com/DarwinAwardWinner/ido-ubiquitous/commits/func-except. It seems to be working, and I'll be submitting a pull request soon after some more testing.

In the meantime, the proper solution is (disable-ido-ubiquitous-in grep-read-files).

@technomancy

This comment has been minimized.

Show comment
Hide comment
@technomancy

technomancy Oct 10, 2011

Owner

Hm; I tested it before committing and it seemed to work fine, but then I realized I hadn't tested it without this change. Turns out it's unnecessary; rgrep works fine already. Is it the read-file-name disable call at the bottom that's causing this?

Owner

technomancy replied Oct 10, 2011

Hm; I tested it before committing and it seemed to work fine, but then I realized I hadn't tested it without this change. Turns out it's unnecessary; rgrep works fine already. Is it the read-file-name disable call at the bottom that's causing this?

Please sign in to comment.