Skip to content

Commit

Permalink
Enough is enough.
Browse files Browse the repository at this point in the history
  • Loading branch information
@technomancy
technomancy committed Apr 27, 2010
1 parent 85b84bc commit 39732d5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/leiningen/new.clj
View file
Expand Up @@ -9,6 +9,8 @@ Neither group-id nor artifact-id may contain slashes."

(defn new
([project-name project-dir]
(when (re-find #"(?<!clo)jure" project-name)
(throw (IllegalArgumentException. "*jure names are no longer allowed.")))
(let [project-name (symbol project-name)
group-id (namespace project-name)
artifact-id (name project-name)]
Expand Down

24 comments on commit 39732d5

@danlarkin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot approve of this change strongly enough.

@bmabey
Copy link
Contributor

@bmabey bmabey commented on 39732d5 Apr 27, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@gstamp
Copy link

@gstamp gstamp commented on 39732d5 Apr 27, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the new name leininjure is out then.

@mtodd
Copy link

@mtodd mtodd commented on 39732d5 Apr 27, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonjour?

@purcell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank goodness for that.

@wlangstroth
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fantastic. I guess I won't be calling my next project "Erajure", then.
"Meajure"?
"Capjure the Flagjure"?

This is cenjureship.

@jwr
Copy link

@jwr jwr commented on 39732d5 Apr 27, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank heavens and technomancy!

@jduey
Copy link

@jduey jduey commented on 39732d5 Apr 27, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@stuartsierra
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. Now if you can also discourage names that have no descriptive relationship to the project, we'll be making progress.

@ghoseb
Copy link
Contributor

@ghoseb ghoseb commented on 39732d5 Apr 28, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why?

@Licenser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch, so one problem as mentioned above what is if someone want's to write clj-bonjour as a bonjour (this apple network stuff) api in clojure? You need to adjust your regexp no not match that!

@geoffsalmon
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great change, but I had to laugh at Licenser's comment. I'm guilty as charged: http://github.com/geoffsalmon/bonjure
A name involving 'zeroconf' would be better anyway...

@petrilli
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that and Bonjour doesn't end 'jure' :)

@Licenser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that just proves why my French teacher gave me a E+ :P

@oslash
Copy link

@oslash oslash commented on 39732d5 May 11, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zeroconjure!

@rplevy
Copy link

@rplevy rplevy commented on 39732d5 Aug 9, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think scriptjure is a pretty great name.

@technomancy
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, scriptjure had already been created when this commit was made. This commit doesn't ban the use of jure names, it only prevents new ones from being created.

@rosejn
Copy link

@rosejn rosejn commented on 39732d5 Dec 12, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when in doubt employ censorship! How about a funny message, but don't deny people.

@technomancy
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosejn that's basically how it works these days; this commit is very old. It aborts, but it tells you how to override it.

@gilesbowkett
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say I've never seen this error message, but I don't want to perjure myself.

@rosejn
Copy link

@rosejn rosejn commented on 39732d5 Dec 12, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, @technomancy my bad. I saw a link to the commit and should have checked the timestamp before commenting.

@hypirion
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosejn, that's exactly how Leiningen has worked for the last 1.5 years (if not more). Whenever you attempt to use *jure names, the following message appears:

Sorry, names such as clojure or *jure are not allowed. 
If you intend to use this name ironically, please set the 
LEIN_IRONIC_JURE environment variable and try again.

Edit: late to the party apparently.

@technomancy
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool story bro

@gilesbowkett
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this cropped up in my notifications, but on re-reading this, I have to say, this was pretty good:

I'd say I've never seen this error message, but I don't want to perjure myself.

pun-husky

Please sign in to comment.