New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade libwagon to version 3.0.0 #2443

Closed
ehashman opened this Issue Jun 24, 2018 · 4 comments

Comments

2 participants
@ehashman
Contributor

ehashman commented Jun 24, 2018

As reported in the dependency cemerick/pomegranate#101, upstream maven is using wagon 3.0.0 and version 2.12 is no longer supported.

Hence, we should upgrade when possible.

@ehashman

This comment has been minimized.

Contributor

ehashman commented Jun 24, 2018

(Note: Leiningen cannot build properly in Debian without bumping this, as Maven has been upgraded to 3.5.3 which is pulling in the new, conflicting libwagon.)

@ehashman

This comment has been minimized.

Contributor

ehashman commented Aug 21, 2018

@winks so good news, turns out this is not blocking Debian (at least from a build perspective). I submitted cemerick/pomegranate#101 and corresponding PR cemerick/pomegranate#103 which passed all tests.

Because Leiningen was failing to build from source in Debian, I had to patch all this stuff to get it working. It hasn't hit testing yet so I can't say for certain but the patched lein seems to be working okay. I think it's pretty safe to proceed with this, the major version bump in wagon didn't appear to be breaking.

@technomancy technomancy added this to the 2.8.2 milestone Sep 20, 2018

@technomancy

This comment has been minimized.

Owner

technomancy commented Sep 21, 2018

@ehashman should be bump this in Leiningen instead of waiting on pomegranate at this point?

@ehashman

This comment has been minimized.

Contributor

ehashman commented Sep 22, 2018

Yeah, I think that will be fine. I haven't gotten any bug reports of bad behaviour with wagon 3.1.0 and I've had that patch in for about a month now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment