Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Leiningen 2 preview2 and Leiningen master produce different dependency versions in pom.xml #500

Closed
michaelklishin opened this Issue · 2 comments

2 participants

@michaelklishin
Collaborator

With Monger I have the following pom.xml files generated by running lein pom on lein2 (preview2) and lein-head (local build from master). Please notice how lein master produced 1.0.x dependency for Validateur while lein2 produces 1.1.x (correctly):

<dependency>
      <groupId>com.novemberain</groupId>
      <artifactId>validateur</artifactId>
      <version>1.0.0</version>
      <scope>test</scope>
</dependency>

with Lein HEAD versus

<dependency>
      <groupId>com.novemberain</groupId>
      <artifactId>validateur</artifactId>
      <version>1.1.0-beta1</version>
      <exclusions></exclusions>
 </dependency>

with Lein2 preview2. Needless to say incorrect dependency versions generated is a very serious issue for library developers and users alike.

@xeqi xeqi closed this in 2d71d28
@xeqi
Collaborator

I did not account for a :dev {:dependency ..}} that contained a different version of a standard :dependency. Fixed in master where it outputs both with a test scope for the :dev one.

    <dependency>
      <groupId>com.novemberain</groupId>
      <artifactId>validateur</artifactId>
      <version>1.1.0-beta1</version>
    </dependency>
    <dependency>
      <groupId>com.novemberain</groupId>
      <artifactId>validateur</artifactId>
      <version>1.0.0</version>
      <scope>test</scope>
    </dependency>

Thanks for catching this.

@michaelklishin
Collaborator

Oh, this may mean my project.clj needs updating then. Still, an interesting edge case. Thanks for fixing it so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.