Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

No way to specify global offline flag #678

Closed
hugoduncan opened this Issue Jul 9, 2012 · 5 comments

Comments

3 participants
Contributor

hugoduncan commented Jul 9, 2012

The only way we expose offline support is via the offline profile, which can only be applied at task run time. In order to prevent snapshot plugins from being re-checked we need something "upstream" of profiles.

Owner

technomancy commented Jul 10, 2012

This works if you put :offline? true in the project. However, the -o task uses with-profiles, which must run after the plugins are loaded. I think there's simply no way to do this via profiles; we can't have tasks that run code before plugins are loaded, since tasks must be able to be loaded from plugins.

Contributor

hugoduncan commented Jul 10, 2012

I would think that using :offline? true in the project map would be the less common scenario. This seems like an unfortunate side-effect of using aliases and with-profiles to process command line arguments.

Owner

technomancy commented Jul 10, 2012

Yeah, I'm not saying this is ideal, just that changing this would involve designing a new way to specify the offline flag; it's not a simple bug fix. I'll re-open and change the issue title to reflect this.

@technomancy technomancy reopened this Jul 10, 2012

Owner

technomancy commented Aug 18, 2012

Honoring an environment variable here is probably our best bet. I can't think of anywhere else to put it if we can't rely on profiles early enough.

Collaborator

michaelklishin commented Sep 18, 2012

Fixed in #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment