Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

No exception mesage shown when `with-profile` catches an exception with `:exit-code` data #764

Closed
hugoduncan opened this Issue · 1 comment

2 participants

@hugoduncan

When a task running under with-profile throws an exception with :exit-code data, the exception's message is never displayed.

I can see two fixes:

  • make with-profile display the exception message
  • make with-profile rethrow the exception

The second seems cleaner to me, but maybe I'm missing a reason why the first should be implemented

@technomancy
Owner

We don't want to re-throw since that would halt the chain of profiles when we want to know how it ran for all of them. (For instance, with the test task.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.