Show uncaught exceptions when using grenchman, don't display "Suppressed exit" when calling exit #1440

Merged
merged 2 commits into from Mar 5, 2014

Conversation

3 participants
@benwbooth
Contributor

benwbooth commented Feb 8, 2014

Fixes #1438 and #1439

@hypirion

This comment has been minimized.

Show comment Hide comment
@hypirion

hypirion Feb 24, 2014

Collaborator

I haven't taken a very deep look into any of these issues and looked for other solutions, so sorry if this is a very straightforward question: I see that both issues are related to the combined use of leiningen, lein-exec and grenchman. Is it possible to fix any of these issues by handling these problems in grenchman or lein-exec?

Collaborator

hypirion commented Feb 24, 2014

I haven't taken a very deep look into any of these issues and looked for other solutions, so sorry if this is a very straightforward question: I see that both issues are related to the combined use of leiningen, lein-exec and grenchman. Is it possible to fix any of these issues by handling these problems in grenchman or lein-exec?

@technomancy

This comment has been minimized.

Show comment Hide comment
@technomancy

technomancy Mar 5, 2014

Owner

Sorry for the delay here. I can see that this makes -main consistent with abort, so it's definitely the right thing to do; thanks for submitting it.

Owner

technomancy commented Mar 5, 2014

Sorry for the delay here. I can see that this makes -main consistent with abort, so it's definitely the right thing to do; thanks for submitting it.

technomancy added a commit that referenced this pull request Mar 5, 2014

Merge pull request #1440 from benwbooth/master
Show uncaught exceptions when using grenchman, don't display "Suppressed exit" when calling exit

@technomancy technomancy merged commit 54156c9 into technomancy:master Mar 5, 2014

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment