Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't call concat #1465

Merged
merged 1 commit into from Mar 8, 2014

Conversation

3 participants
Collaborator

gfredericks commented Mar 8, 2014

There, now there is slightly less code.

Do we like these kind of trivial cleanup commits?

@gfredericks gfredericks Don't call concat
There, now there is slightly less code.
b6c079f
Collaborator

hyPiRion commented Mar 8, 2014

Sure, I think that would be really handy for readability. Although if you find more, a single commit for all of them would be nice.

I'll merge this one in anyway, thanks! :)

@hyPiRion hyPiRion added a commit that referenced this pull request Mar 8, 2014

@hyPiRion hyPiRion Merge pull request #1465 from fredericksgary/cleanup
Don't call concat
291b090

@hyPiRion hyPiRion merged commit 291b090 into technomancy:master Mar 8, 2014

1 check passed

default The Travis CI build passed
Details
Owner

technomancy commented Mar 8, 2014

Definitely like getting small cleanups like this. I've added you so you can commit directly to master next time if you like, but feel free to do a PR even so if you'd like another set of eyes on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment