Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Don't call concat #1465

Merged
merged 1 commit into from

3 participants

Gary Fredericks Jean Niklas L'orange Phil Hagelberg
Gary Fredericks
Collaborator

There, now there is slightly less code.

Do we like these kind of trivial cleanup commits?

Gary Fredericks gfredericks Don't call concat
There, now there is slightly less code.
b6c079f
Jean Niklas L'orange
Collaborator

Sure, I think that would be really handy for readability. Although if you find more, a single commit for all of them would be nice.

I'll merge this one in anyway, thanks! :)

Jean Niklas L'orange hyPiRion merged commit 291b090 into from
Phil Hagelberg
Owner

Definitely like getting small cleanups like this. I've added you so you can commit directly to master next time if you like, but feel free to do a PR even so if you'd like another set of eyes on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 8, 2014
  1. Gary Fredericks

    Don't call concat

    gfredericks authored
    There, now there is slightly less code.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/leiningen/repl.clj
2  src/leiningen/repl.clj
View
@@ -73,7 +73,7 @@
;; move other source/javadoc/etc references into longer help.
:welcome (list 'println (slurp (io/resource "repl-welcome")))}
opts)
- (apply dissoc opts (concat [:init] (if attach [:host :port])))
+ (apply dissoc opts :init (if attach [:host :port]))
(merge opts (cond attach {:attach (str attach)}
port {:port port}
:else {}))
Something went wrong with that request. Please try again.