Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :pprint-edn to eval-in #1957

Merged
merged 1 commit into from Mar 27, 2017
Merged

Conversation

laurentpetit
Copy link
Contributor

  • factorized code for runtime-info to emit intermediate datastructure
  • use new runtime-info fn from eval-in :pprint (no regression)
  • add new flavor eval-in :pprint-edn which pprints everything read-ably

- factorized code for runtime-info to emit intermediate datastructure
- use new runtime-info fn from eval-in :pprint (no regression)
- add new flavor eval-in :pprint-edn which pprints everything read-ably
@laurentpetit
Copy link
Contributor Author

First trial at a proposal for #1956

@hypirion hypirion added this to the 2.6.0 milestone Sep 26, 2015
@hypirion hypirion self-assigned this Jan 4, 2016
@hypirion
Copy link
Collaborator

@laurentpetit Terribly sorry for the late response time here. This seems fine by me, but I wonder about one thing: Would it be easier or harder for you to read the output if we were to incorporate the form into the map? Currently it emits two values, which may be slightly awkward to work with.

I have no preference over either, but I would assume embedding the form into the map would be easier to work with for consumers.

@hypirion hypirion modified the milestones: 2.6.0, 2.6.1, 2.6.2 Feb 5, 2016
@hypirion hypirion modified the milestones: 2.6.2, 2.7.1 Aug 30, 2016
@technomancy
Copy link
Owner

Just took a look at this, and it looks great. Unless @laurentpetit wants to make the change to a single form containing both pieces of data, I'd like to go ahead and merge it.

@laurentpetit
Copy link
Contributor Author

Actually, it's so old that I doubt it will be used by Counterclockwise soon. Indeed the project is in maintenance mode, and I'm not working on it anymore.

Anyway, there's still value in the PR so feel free to merge it! Just saying!

@technomancy technomancy merged commit 26d530b into technomancy:stable Mar 27, 2017
@technomancy
Copy link
Owner

OK, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants