Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nREPL to 0.4.3 #2444

Merged
merged 3 commits into from Jul 27, 2018
Merged

Update nREPL to 0.4.3 #2444

merged 3 commits into from Jul 27, 2018

Conversation

@bbatsov
Copy link
Contributor

bbatsov commented Jun 26, 2018

As no one really commented on #2434 I've decided to try an alternative approach. Here's my preferred (quick) solution to the migration to the new nREPL. I know this is probably less than ideal, but it's a one time deal, and I'd really appreciate your support as I rather be dealing with nREPL improvements than with migration paths.

nREPL was recently moved out of clojure-contrib and its development
continued under a dedicated org (https://github.com/nrepl). The new project is (and will remain
to be) completely backwards compatible on the nREPL API level, but
the namespace had to be changed.

This fixes #2434.

nREPL was recently moved out of clojure-contrib and its development
continued under a dedicated org (https://github.com/nrepl). The new project is (and will remain
to be) completely backwards compatible on the nREPL API level, but
the namespace had to be changed.

This fixes #2434.
@bbatsov bbatsov force-pushed the bbatsov:new-nrepl branch from 368c3ce to 008844e Jun 26, 2018
@bbatsov

This comment has been minimized.

Copy link
Contributor Author

bbatsov commented Jun 29, 2018

@bbatsov

This comment has been minimized.

Copy link
Contributor Author

bbatsov commented Jul 17, 2018

I've also created one simple plugin, so people can easily use nREPL 0.4, while waiting for this to be merged. (https://github.com/nrepl/lein-nrepl)

@@ -54,7 +54,7 @@
org.apache.maven/maven-resolver-provider "3.5.0"
org.clojure/data.xml "0.0.8"
org.clojure/tools.macro "0.1.5"
org.clojure/tools.nrepl "0.2.12"
nrepl "0.4.1g"

This comment has been minimized.

Copy link
@razum2um

This comment has been minimized.

Copy link
@bbatsov

bbatsov Jul 26, 2018

Author Contributor

Fixed.

bbatsov added 2 commits Jul 26, 2018
@bbatsov

This comment has been minimized.

Copy link
Contributor Author

bbatsov commented Jul 26, 2018

I've updated the PR to nREPL 0.4.3.

@bbatsov bbatsov changed the title Update nREPL to 0.4.1 Update nREPL to 0.4.3 Jul 26, 2018
@technomancy

This comment has been minimized.

Copy link
Owner

technomancy commented Jul 27, 2018

Looks good; thanks.

@technomancy technomancy merged commit 7357010 into technomancy:master Jul 27, 2018
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@bbatsov

This comment has been minimized.

Copy link
Contributor Author

bbatsov commented Jul 28, 2018

🙇

@bbatsov bbatsov deleted the bbatsov:new-nrepl branch Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.