Re-enable post-compile cleaning. #675

Merged
merged 3 commits into from Jul 6, 2012

Conversation

4 participants
Contributor

kivikakk commented Jul 6, 2012

Addresses(?) #516.

I've had a look around, and don't see any tests that related to this specifically. The commit that took out this functionality (b1046bc) didn't comment out any tests at the same time, so …

My feeling is it'd be a decent idea to add tests while we're here, rather than just re-enable this swathe of code. What do you think?

Arlen Cuss Re-enable post-compile cleaning.
See technomancy/leiningen#516.  AOT can bring in other .classes which we
don't want for ourselves.  It was disabled for 2.x, but seems fine in
1.x.
62d4921
Collaborator

michaelklishin commented Jul 6, 2012

Feel free to add them

This pull request passes (merged 62d4921 into 5120d24).

Contributor

kivikakk commented Jul 6, 2012

@michaelklishin: ta, will give it a go! :)

Contributor

kivikakk commented Jul 6, 2012

It turns out there were some tests, they were just marked :post-preview and I didn't realise it. We did have 6 failures in leiningen.test.compile :all, now zero.

Should these still be marked :post-preview?

This pull request passes (merged e39397c into 5120d24).

Collaborator

michaelklishin commented Jul 6, 2012

@unnali given that Preview 7 is likely to be the last preview before 2.0 RC1, I don't think so.

Contributor

kivikakk commented Jul 6, 2012

@michaelklishin Okay, great; that's done. These will now be included as part of the test by Travis, woo. Last question: do you want these to be factored into one commit, or is it fine as-is?

This pull request passes (merged 710849c into 5120d24).

Collaborator

michaelklishin commented Jul 6, 2012

@unnali we are not too picky about how many commits there are, it's fine as it is

michaelklishin merged commit 5afa5bf into technomancy:master Jul 6, 2012

Owner

technomancy commented Jul 6, 2012

Thanks for adding this back in.

Contributor

kivikakk commented Jul 8, 2012

Happy to help! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment