I've had a look around, and don't see any tests that related to this specifically. The commit that took out this functionality (b1046bc) didn't comment out any tests at the same time, so …
My feeling is it'd be a decent idea to add tests while we're here, rather than just re-enable this swathe of code. What do you think?
Re-enable post-compile cleaning.
See technomancy/leiningen#516. AOT can bring in other .classes which we
don't want for ourselves. It was disabled for 2.x, but seems fine in
Feel free to add them
This pull request passes (merged 62d4921 into 5120d24).
@michaelklishin: ta, will give it a go! :)
Fix existing :post-preview tests for cleanup.
It turns out there were some tests, they were just marked :post-preview and I didn't realise it. We did have 6 failures in leiningen.test.compile :all, now zero.
Should these still be marked :post-preview?
This pull request passes (merged e39397c into 5120d24).
@unnali given that Preview 7 is likely to be the last preview before 2.0 RC1, I don't think so.
Unmark :post-preview compile tests.
@michaelklishin Okay, great; that's done. These will now be included as part of the test by Travis, woo. Last question: do you want these to be factored into one commit, or is it fine as-is?
This pull request passes (merged 710849c into 5120d24).
@unnali we are not too picky about how many commits there are, it's fine as it is
Thanks for adding this back in.
Happy to help! :)