Removes run task aliases within metadata. fix #882 #883

Merged
merged 1 commit into from Dec 11, 2012

Conversation

2 participants
@hypirion
Collaborator

hypirion commented Dec 11, 2012

This seems to be an issue specifically regarding with-profile, as it reapplies profiles through set-profiles[1]. apply-task removes the alias from the :aliases map, but as init-profiles refetches the profile from the metadata, the alias has to be removed from there as well to prevent it from being used again.

This patch removes the task to be run residing within a project's metadata (inside :without-profiles) in addition to the original map, in order to prevent "with-profile" from reviving already used aliases, and thus fixes #882.

Removes run task aliases within metadata. fix #882
Removes the task to be run residing within a project's metadata (inside
:without-profiles) in addition to the original map, in order to prevent
"with-profile" from reviving already used aliases.
@technomancy

This comment has been minimized.

Show comment Hide comment
@technomancy

technomancy Dec 11, 2012

Owner

Nice work; thanks for tracking this down.

Owner

technomancy commented Dec 11, 2012

Nice work; thanks for tracking this down.

technomancy added a commit that referenced this pull request Dec 11, 2012

Merge pull request #883 from hyPiRion/fix-with-profile-recursive-aliases
Removes run task aliases within metadata. fix #882

@technomancy technomancy merged commit b4558ec into technomancy:master Dec 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment