Hooked clojure.test report function should pass invocation through to original fn #914

Merged
merged 1 commit into from Jan 10, 2013

Conversation

2 participants
@senior
Contributor

senior commented Jan 10, 2013

Currently Leiningen is intercepting the call to report, not letting it pass through to the function it's hooking. I have a custom report function that worked under lein 1 but never gets called in lein 2.

Couldn't think of a great way to test it, other than just adding the multi-method and checking that it's being called.

changed leiningen/test to allow the call into the clojure.test report to
pass through the hook to  the original multimethod
@technomancy

This comment has been minimized.

Show comment Hide comment
@technomancy

technomancy Jan 10, 2013

Owner

Good call; thanks. I hate the fact that we have to monkeypatch this, so anything we can do to play nicely is appreciated.

Owner

technomancy commented Jan 10, 2013

Good call; thanks. I hate the fact that we have to monkeypatch this, so anything we can do to play nicely is appreciated.

technomancy added a commit that referenced this pull request Jan 10, 2013

Merge pull request #914 from revelytix/test-report-hook
Hooked clojure.test report function should pass invocation through to original fn

@technomancy technomancy merged commit 3d1aac4 into technomancy:master Jan 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment