Messes up namespace docstrings that have numbers in them #40

Closed
AlexBaranosky opened this Issue May 1, 2013 · 2 comments

2 participants

@AlexBaranosky
(ns furtive.test.spec-utils.rules-situations
  "Functions to setup the rules that represent certain situations in the
   processing of runtime system requests. Uses only production code!

   Rules are assumed to work against merchant \"14\""
  (:require [clojure.test :refer :all]
            [furtive.session.persistence.session-persistence :as session-persistence]
            [furtive.rules.feature-bits-store :as feature-bits]
            [furtive.rules.rules :as rules]
            [furtive.rules.state :refer [RULES]]
            [kits.contextual-logging :as log]
            [furtive.io.rabbitmq :as rabbit]
            [furtive.promos.promos :as promos]))

;; gets turned into:

(ns furtive.test.spec-utils.rules-situations
  "Functions to setup the rules that represent certain situations in the
   processing of runtime system requests. Uses only production code!

   Rules are assumed to work against merchant "14""  ;; <-- note this 14
  (:require [furtive.rules.feature-bits-store :as feature-bits]
            [furtive.rules.rules :as rules]
            [kits.contextual-logging :as log]
            [furtive.rules.state :refer [RULES]]))
@guns guns added a commit to guns/slamhound that referenced this issue Jun 6, 2013
@guns guns Fix docstring unescaping
Addresses #40

prettify used the cl-format ~A directive to print strings, then
re-surrounded them with quotes. This erroneously unescaped the string.

The proper way is to use the ~S directive to print the string as an
S-expression, escaping both quotes and backslashes to survive a (read)
correctly.

refer: https://www.cs.cmu.edu/afs/cs.cmu.edu/project/ai-repository/ai/html/cltl/clm/node200.html#SECTION002633000000000000000
e66a406
@guns
Collaborator

This issue was fixed with #42; please confirm

@AlexBaranosky

Nice. That looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment