Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update to README, and resource leak fix #39

Merged
merged 2 commits into from Apr 9, 2013

Conversation

Projects
None yet
2 participants
Contributor

RadicalZephyr commented Apr 9, 2013

The README was pointing people to an older version of slamhound, that still had a problem with truncating large files.

Also, I believe that there was a file leak going on in swap-in-reconstructed-ns-form where the PushBackReader created was never closed. This tends to work fine with a deleteOnExit file under Linux, but I know from experience that it will cause the file not to be deleted under Windows.

RadicalZephyr added some commits Apr 8, 2013

@RadicalZephyr RadicalZephyr Update version reference to latest
And fix a small grammatical error
35b3cb1
@RadicalZephyr RadicalZephyr Make sure the PushBackReader is actually closed
clojure.java.io/copy doesn't close streams it didn't open.
9f3bd30

@technomancy technomancy added a commit that referenced this pull request Apr 9, 2013

@technomancy technomancy Merge pull request #39 from ezephyr/master
Update to README, and resource leak fix
9aafef1

@technomancy technomancy merged commit 9aafef1 into technomancy:master Apr 9, 2013

Owner

technomancy commented Apr 9, 2013

Nice catch; thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment