Honor existing refer all #50

Merged
merged 2 commits into from Sep 13, 2013

Projects

None yet

2 participants

@guns
Collaborator
guns commented Sep 13, 2013

When an old namespace contains a require :refer :all that satisfies a missing var, choose this over a list of vars.

This allows the user to use :refer :all on namespaces of his choosing without separate configuration for slamhound.

As discussed in #29

guns added some commits Aug 8, 2013
@guns guns Revert "clojure.test is always :refer :all"
This reverts commit b7b3472.

"I'll be more opinionated then: fewer special cases is good. =) I agree
that clojure.test shouldn't be a special case."

        - technomancy

technomancy#29

Conflicts:
	project.clj
	src/slam/hound/stitch.clj
970cac4
@guns guns Honor existing :refer :all requires
From #29

> The ability to add :refer :all namespaces on a per-project basis might
> be good

I think that's a great solution.

> but I haven't figured out a clean way to pass configuration options to
> slamhound

A no-configuration way is to simply honor existing :refer :all imports
and move on (but not :use!). When the user decides he'd like to tidy his
namespace, he can simply remove that expression and re-run Slamhound.

technomancy#29 (comment)
28d353b
@technomancy technomancy merged commit b534bae into technomancy:master Sep 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment