Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix detection of dotted ns alias #87
Conversation
This comment has been minimized.
This comment has been minimized.
I'll show an example to explain a bit more about this, and why I think it's an important issue: With the current version of slamhound, I get the following:
And the file was untouched. Without
With this PR applied:
Summary: Dotted namespaces are not only respected but are inferred to:
@guns: I'd like to know your thoughts about this. I can't say that the implementation is elegant, but it seems to work and is in line with the overally strategy. To me, this is a blocking issue. I like to be able to use slamhound when I use dotted aliases. One could say "Why are you using
|
nberger commentedJun 3, 2015
Due to http://dev.clojure.org/jira/browse/CLJ-1403, a dotted ns alias like
[clojure.java.io :as java.io]
or[clj-time.coerce :as time.coerce]
throws aClassNotFoundException
with the ns alias as the message. Identifying this special case in the regrow process allows us to keep looking for the correct alias