From 05783a21f8c488822c9a4e4ab2d6fd3d30a55fcd Mon Sep 17 00:00:00 2001 From: Erik Michaels-Ober Date: Wed, 13 Oct 2010 15:15:54 -0700 Subject: [PATCH 1/3] Update addressable dependency --- Gemfile.lock | 14 +++++++------- faraday.gemspec | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 10b970521..df828e393 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,17 +1,17 @@ PATH remote: . specs: - faraday (0.4.6) - addressable (~> 2.1.1) + faraday (0.5.0) + addressable (~> 2.2.2) multipart-post (~> 1.0.1) - rack (~> 1.0.1) + rack (~> 1.2.1) GEM remote: http://rubygems.org/ specs: - addressable (2.1.2) + addressable (2.2.2) multipart-post (1.0.1) - rack (1.0.1) + rack (1.2.1) rake (0.8.7) sinatra (1.0) rack (>= 1.0) @@ -20,9 +20,9 @@ PLATFORMS ruby DEPENDENCIES - addressable (~> 2.1.1) + addressable (~> 2.2.2) faraday! multipart-post (~> 1.0.1) - rack (~> 1.0.1) + rack (~> 1.2.1) rake (~> 0.8.7) sinatra (~> 1.0.0) diff --git a/faraday.gemspec b/faraday.gemspec index 8e9fd4ed0..b0c7ea6fd 100644 --- a/faraday.gemspec +++ b/faraday.gemspec @@ -35,7 +35,7 @@ Gem::Specification.new do |s| s.add_development_dependency('rake', ['~> 0.8.7']) s.add_development_dependency('sinatra', ['~> 1.0.0']) - s.add_runtime_dependency('addressable', ['~> 2.1.1']) + s.add_runtime_dependency('addressable', ['~> 2.2.2']) s.add_runtime_dependency('multipart-post', ['~> 1.0.1']) s.add_runtime_dependency('rack', ['~> 1.2.1']) @@ -87,4 +87,4 @@ Gem::Specification.new do |s| ## Test files will be grabbed from the file list. Make sure the path glob ## matches what you actually use. s.test_files = s.files.select { |path| path =~ /^test\/.*_test\.rb/ } -end \ No newline at end of file +end From 04a61c25be6ce1549f4e09b691137fa99da83ffd Mon Sep 17 00:00:00 2001 From: Erik Michaels-Ober Date: Wed, 13 Oct 2010 15:17:07 -0700 Subject: [PATCH 2/3] Add descriptions for all rake tasks --- Rakefile | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Rakefile b/Rakefile index ea1ead428..f25712417 100644 --- a/Rakefile +++ b/Rakefile @@ -71,6 +71,7 @@ end # ############################################################################# +desc "Create tag v#{version} and build and push #{gem_file} to Rubygems" task :release => :build do unless `git branch` =~ /^\* master$/ puts "You must be on the master branch to release!" @@ -80,15 +81,17 @@ task :release => :build do sh "git tag v#{version}" sh "git push origin master" sh "git push origin v#{version}" - sh "gem push pkg/#{name}-#{version}.gem" + sh "gem push pkg/#{gem_file}" end +desc "Build #{gem_file} into the pkg directory" task :build => :gemspec do sh "mkdir -p pkg" sh "gem build #{gemspec_file}" sh "mv #{gem_file} pkg" end +desc "Generate #{gemspec_file}" task :gemspec => :validate do # read spec file and split out manifest section spec = File.read(gemspec_file) @@ -117,6 +120,7 @@ task :gemspec => :validate do puts "Updated #{gemspec_file}" end +desc "Validate #{gemspec_file}" task :validate do libfiles = Dir['lib/*'] - ["lib/#{name}.rb", "lib/#{name}"] unless libfiles.empty? @@ -127,4 +131,4 @@ task :validate do puts "A `VERSION` file at root level violates Gem best practices." exit! end -end \ No newline at end of file +end From 6034a5b0a1e8a37b23cadb482ac47a9b6ae80958 Mon Sep 17 00:00:00 2001 From: Erik Michaels-Ober Date: Wed, 13 Oct 2010 15:24:46 -0700 Subject: [PATCH 3/3] Fix documentation bug. Closes #8 --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3ac3bc188..cfd504001 100644 --- a/README.md +++ b/README.md @@ -22,7 +22,7 @@ This mess is gonna get raw, like sushi. So, haters to the left. resp1 = conn.get '/nigiri/sake.json' resp2 = conn.post do |req| req.url "/nigiri.json", :page => 2 - req[:content_type] = 'application/json' + req["Content-Type"] = 'application/json' req.body = {:name => 'Unagi'} end