Support for .cat TLD domains #20

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Hi,

I've added support for .cat TLD domains on Authentication.domain_tld_regex. See http://www.domini.cat/en_index.html for more info.

Kind regards,
Francisco.

I know this is pretty old, but I'm wondering if anyone can comment on the logic behind listing out all supported tlds with more than 2 characters, rather than using something like "(?:[A-Z]{2,})" for the expression. Is there something horrible about that solution that I'm not seeing?

trejkaz commented Mar 11, 2013

I'm not convinced that anyone is looking at the issues on this project, but in case someone does end up here, I raised a very similar ticket on someone else's fork, only I didn't just fix it for .cat - https://github.com/jeremydurham/restful-authentication/pull/1

I don't think this will get integrated after 3 years, so I'm closing it :P

franciscoj closed this Mar 18, 2014

trejkaz commented Mar 19, 2014

Well, as long as someone makes the obvious alternative improvement of just not restricting the TLD at all, I wouldn't object. (Incidentally, I didn't find it for .cat, there was some other domain a customer was actually using.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment