Skip to content

CVE-2023-34796 -- XSS: Escape Raw HTML in Outputs#88

Merged
techsneeze merged 2 commits intotechsneeze:masterfrom
NotsoanoNimus:hotfix/sanitize-printed-data
May 31, 2023
Merged

CVE-2023-34796 -- XSS: Escape Raw HTML in Outputs#88
techsneeze merged 2 commits intotechsneeze:masterfrom
NotsoanoNimus:hotfix/sanitize-printed-data

Conversation

@NotsoanoNimus
Copy link
Contributor

Resolve an issue where malicious XSS injected into the XML for org_name or domain values can anonymously target email admins accessing the PHP dashboard and execute arbitrary JavaScript remotely.

A technical exploration is available on my blog.

@jnew-gh
Copy link
Contributor

jnew-gh commented May 31, 2023

@NotsoanoNimus, thanks for the article and pull request.

I am going to quote your article that gets to the meat of the bug:

This whole segment is a verbose way to say, “The ‘Organization’ and ‘Domain’ fields are 255-character data fields which are fully unsanitized when parsed from DMARC reports and are injected into the main dashboard page without a second glance. These raw strings can arrive from anyone because DMARC reporting mailboxes are by design public destinations.”

or to put it another way. Lesson learned.

I won't lie but I will have to read the "Exploitation" section of your blog post several times to fully understand the mechanics of the exploit but essentially the fix is to sanitize the html inputs for “The ‘Organization’ and ‘Domain’ fields. A very straightforward fix to a dangerous bug.

@techsneeze I see no reason not to merge this PR asap.

@techsneeze techsneeze merged commit 8a1d882 into techsneeze:master May 31, 2023
@NotsoanoNimus NotsoanoNimus deleted the hotfix/sanitize-printed-data branch May 31, 2023 12:41
@NotsoanoNimus NotsoanoNimus changed the title XSS: Escape Raw HTML in Outputs CVE-2023-34796 -- XSS: Escape Raw HTML in Outputs Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants