Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RenameCommand #39

Merged
merged 2 commits into from Jan 21, 2019

Conversation

Projects
None yet
3 participants
@slig3
Copy link
Contributor

commented Nov 27, 2018

Be able to select a step in a .feature file and rename it using Visual Studio rename shortcut.
The user is prompted to modify the regex in the binding attribute of the step definition.
Then, the modification on the regex is applied on all the steps that are bound to this method.
The values specified in the step names are conserved after the name change.

Catherine Tetreault-Beaulieu added some commits Nov 27, 2018

Catherine Tetreault-Beaulieu Catherine Tetreault-Beaulieu
Update RenameCommand.cs
Modify error message when no or too many bindings have been found.
Replace only regex that perfectly match the rename, not the others.
@SabotageAndi

This comment has been minimized.

Copy link
Collaborator

commented Dec 3, 2018

@slig3 Thanks for the PR. This would be a nice feature for the VS Extension.
Is this PR finished to look at?

@slig3

This comment has been minimized.

Copy link
Contributor Author

commented Dec 3, 2018

@SabotageAndi Yes, I finished to look at this PR. Should I close it or other people want to look at this?

@SabotageAndi

This comment has been minimized.

Copy link
Collaborator

commented Dec 3, 2018

@slig3 I will have a look at it and will merge it or give you some comments.
Please don't close the PR, because then I can't merge it.

@SabotageAndi

This comment has been minimized.

Copy link
Collaborator

commented Dec 3, 2018

Btw, it could take some days until I find the time to do the review

@slig3

This comment has been minimized.

Copy link
Contributor Author

commented Dec 3, 2018

No problem. Thanks a lot!

@slig3

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

@SabotageAndi Hi, I was wondering if you had time to look at this PR?

@SabotageAndi

This comment has been minimized.

Copy link
Collaborator

commented Jan 16, 2019

facepalm

Oops. Sorry, I forgot this PR.
I will look at it next Monday.

@SabotageAndi SabotageAndi merged commit ceadcf7 into techtalk:master Jan 21, 2019

@SabotageAndi

This comment has been minimized.

Copy link
Collaborator

commented Jan 21, 2019

@slig3 So, I had a look at it.
It worked really good. Thanks for this PR. You will be in the hearth of a lot of SpecFlow users from now on.

@Stephen-Mc

This comment has been minimized.

Copy link

commented Apr 5, 2019

Thanks for your contribution to SpecFlow. If you would like us to send you some SpecFlow stickers as a thank you, please fill out the form here.

littlegenius666 pushed a commit to littlegenius666/SpecFlow.VisualStudio that referenced this pull request May 3, 2019

Add RenameCommand (techtalk#39)
Be able to select a step in a .feature file and rename it using Visual Studio rename shortcut.
The user is prompted to modify the regex in the binding attribute of the step definition.
Then, the modification on the regex is applied on all the steps that are bound to this method.
The values specified in the step names are conserved after the name change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.