New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gherkin parser #1015

Merged
merged 5 commits into from Jan 30, 2018

Conversation

Projects
None yet
1 participant
@SabotageAndi
Collaborator

SabotageAndi commented Jan 30, 2018

No description provided.

@SabotageAndi

This comment has been minimized.

Collaborator

SabotageAndi commented Jan 30, 2018

@gasparnagy I had to build my own Gherkin nuget package, because the one on nuget.org doesn't include the assembly for .NET 4.5
And I had upgrade again to Json.Net 9, because the Gherkin parser depends on it.

@SabotageAndi

This comment has been minimized.

Collaborator

SabotageAndi commented Jan 30, 2018

@gasparnagy The Gherkin 4.0 parser is the reason for the "Loading this assembly would produce a different grant set from other instances." error of techtalk/SpecFlow.VisualStudio#26.

The reason is when we are loading the json file with the languages: https://github.com/cucumber/gherkin-dotnet/blob/v4.0.0/Gherkin/GherkinDialectProvider.cs#L67
In this version, we where using the Json Deserializer from System.Web.Extensions. The call into this made the exception.

Perhaps this is also the reason for #857?

@SabotageAndi

This comment has been minimized.

Collaborator

SabotageAndi commented Jan 30, 2018

@gasparnagy Are 👍 your new method of approving my PRs? ;-)

@SabotageAndi SabotageAndi merged commit 065dd2f into techtalk:master Jan 30, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@SabotageAndi SabotageAndi deleted the SabotageAndi:UpdateGherkinParser branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment