Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] .NET Core/Standard support #649

Merged
merged 345 commits into from Oct 17, 2018

Conversation

@SabotageAndi
Copy link
Collaborator

commented Jun 17, 2016

@mnadeau2

This comment has been minimized.

Copy link

commented Sep 12, 2016

Hi, we are waiting on this merge.

@SabotageAndi

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 12, 2016

@arcaner Good to know that someone is interessted in .NET Core support.
Currently this PR is still in progress and there is still a lot of work todo, so it could take a while until it is finished.

@asiffermann

This comment has been minimized.

Copy link

commented Sep 12, 2016

@arcaner In the meantime, there is a temporary solution using SpecFlow.NetCore
@SabotageAndi We are also really interested in .NET Core support, if it has to be noticed ! :)

@arnaudauroux

This comment has been minimized.

Copy link

commented Sep 12, 2016

@SabotageAndi @asiffermann Yes me too ! :)

@samholder

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2016

Good to see so many people volunteering to help out with the PR! 😉

@ngm

This comment has been minimized.

Copy link

commented Sep 13, 2016

I'd be interested in helping out with this PR. I'd be keen on the netstandard support, as I'd like to run SpecFlow on Ubuntu. @SabotageAndi is there anywhere in particular I can help? I'm also happy to just jump in and give it a go and report back.

@SabotageAndi

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 14, 2016

@ngm Help is always appreciate. To be honest, I can't remember the current state of this PR.
But I will have a look at it in the next 2 weeks.
Then I will update the Todo list in the description.

@stuartleeks

This comment has been minimized.

Copy link

commented Sep 15, 2016

I'd also be interested in helping with the .NET Core work if there's anything that I can usefully do? I'd love to use it in a project I'm working on :-)

Any pointer for where it makes sense to start would be gratefully received

@SabotageAndi

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 20, 2016

@ngm @stuartleeks @asiffermann @arcaner @arnaudauroux
Which netstandard level should we target? What are you using in your projects?

@arnaudauroux

This comment has been minimized.

Copy link

commented Sep 20, 2016

@SabotageAndi 1.3 should be fine ;) Thx

@stuartleeks

This comment has been minimized.

Copy link

commented Sep 20, 2016

For the work I'm currently doing, I can't see a problem with requiring that the test project targets netcoreapp1.0 if that helps to get a version out :-) [Providing it also targets .NET 4.x]
I'm using xunit for unit tests and the .NET Core docs for that point to netcoreapp1.0: https://xunit.github.io/docs/getting-started-dotnet-core.html

As per the docs, netcoreapp1.0 implements netstandard1.6: https://docs.microsoft.com/en-us/dotnet/articles/standard/library

@asiffermann

This comment has been minimized.

Copy link

commented Sep 21, 2016

@SabotageAndi I would like to use SpecFlow to test ASP.NET Core applications, so same as @stuartleeks, netcoreapp1.0 (netstandard1.6) and .NET 4.5.2+ should be enough!
If I can help with this PR too, just let us know where to start :)

@ngm

This comment has been minimized.

Copy link

commented Sep 21, 2016

@SabotageAndi I'm making ASP.NET Core applications, and class libraries, on Ubuntu - so netcoreapp1.0 and netstandard1.6 should be good :)

@ngm

This comment has been minimized.

Copy link

commented Sep 21, 2016

There is a netstandard2.0 in the pipeline, but quite a long way away (Q1/Q2 2017 - https://blogs.msdn.microsoft.com/dotnet/2016/07/15/net-core-roadmap/). It seems netstandard1.6 will be the latest standard for the next 6 months or so, and then forwards compatible to netstandard2.0.

EDIT: actually there does seem to be a netcoreapp1.1 and netstandard1.7 somewhere in the pipeline - NuGet/NuGet.Client#722, although not much official mention of it that I can see. That said, netcoreapp1.0 and netstandard1.6 would seem the stable path for now :)

@SabotageAndi

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 7, 2016

As netstandard1.5 is declared as dead (https://blogs.msdn.microsoft.com/dotnet/2016/09/26/introducing-net-standard/), it will be max. netstandard1.4.

@wmeints

This comment has been minimized.

Copy link

commented Nov 9, 2016

With the new MSBuild project file format coming soon. What are the ideas on how to generate the codebehind for the specflow files?

@wmeints wmeints referenced this pull request Nov 9, 2016
@wmeints

This comment has been minimized.

Copy link

commented Nov 9, 2016

@SabotageAndi I was wondering if I can put in some time to help this move forward.
Specifically I would like to take a look at the tests and make those work properly.

Is this something you would be interested in?

@SabotageAndi

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 9, 2016

Yes, help is always useful. In the last weeks I had a lot of other things to do, so I wasn't able to continue. Next week I will look at it and get a list with missing pieces and a plan how to continue.

@wmeints

This comment has been minimized.

Copy link

commented Nov 9, 2016

Other things I see that aren't working yet and definitely need some love:

  • CodeDom is not supported in .NET Standard
  • .NET Standard support for the Gherkin parser (we're going to need the guys from Gherkin on this)

And there's tons more, but I will go take a look at the tests first.

@jmezach

This comment has been minimized.

Copy link

commented Nov 21, 2016

@wmeints Looks like .NET Core support for the Gherkin parses is already in progress in cucumber-attic/gherkin#215.

@asherber asherber referenced this pull request Jan 18, 2017
@shivarayapa

This comment has been minimized.

Copy link

commented Oct 3, 2018

Hi. What is the proposed date for release of .net core Support for SpecFlow? Any mile store date available? Where can I get this info?

@SabotageAndi

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 3, 2018

@shivarayapa You find the status here: https://github.com/techtalk/SpecFlow/projects/2
We are working hard on it and hope that we will release in the next weeks a first pre-release to the public.

@robcthegeek robcthegeek referenced this pull request Oct 9, 2018
0 of 13 tasks complete
SabotageAndi added 22 commits Oct 11, 2018
Merge branch 'master' into DotNetCore
# Conflicts:
#	TechTalk.SpecFlow/TechTalk.SpecFlow.csproj
#	Tests/TechTalk.SpecFlow.RuntimeTests/AssistTests/ServiceComponentListTests.cs
#	Tests/TechTalk.SpecFlow.RuntimeTests/AssistTests/ServiceTests.cs
#	Tests/TechTalk.SpecFlow.RuntimeTests/TestRunnerManagerRunnerCreationTests.cs
#	Tests/TechTalk.SpecFlow.Specs/Features/Execution/Tracing.feature
Merge branch 'master' into DotNetCore
# Conflicts:
#	SpecFlow.TestGenerator/SpecFlow.TestProjectGenerator/TestProjectTemplates/TestProjectFile.csproj
#	SpecFlow.TestGenerator/SpecFlow.TestProjectGenerator/TestProjectTemplates/TestProjectFile.vbproj
#	SpecFlow.TestGenerator/SpecFlow.TestProjectGenerator/TestProjectTemplates/TestProjectFile_Before20.csproj
#	TechTalk.SpecFlow.Parser/TechTalk.SpecFlow.Parser.csproj
#	TechTalk.SpecFlow.Reporting/TechTalk.SpecFlow.Reporting.csproj
#	TechTalk.SpecFlow/FeatureContext.cs
#	TechTalk.SpecFlow/Properties/AssemblyInfo.cs
#	TechTalk.SpecFlow/ScenarioContext.cs
#	TechTalk.SpecFlow/SpecFlow.nuspec
#	TechTalk.SpecFlow/TechTalk.SpecFlow.csproj
#	TechTalk.SpecFlow/packages.config
#	Tests/TechTalk.SpecFlow.Specs/Drivers/Templates/TestProjectFile.csproj
#	Tests/TechTalk.SpecFlow.Specs/Drivers/Templates/TestProjectFile.fsproj
#	Tests/TechTalk.SpecFlow.Specs/Drivers/Templates/TestProjectFile.vbproj
Merge branch 'master' into DotNetCore
# Conflicts:
#	TechTalk.SpecFlow/Properties/AssemblyInfo.cs
#	TechTalk.SpecFlow/TechTalk.SpecFlow.csproj
Merge branch 'master' into DotNetCore
# Conflicts:
#	TechTalk.SpecFlow.Reporting/NUnitExecutionReport/NUnitExecutionReport.xslt
#	Tests/TechTalk.SpecFlow.Specs/Features/Reports/ExecutionReport.feature

@SabotageAndi SabotageAndi merged commit 652ed71 into master Oct 17, 2018

1 check passed

SpecFlow.CI #SpecFlow.CI succeeded
Details

.NET Core Support automation moved this from In Progess to Done Oct 17, 2018

@SabotageAndi SabotageAndi deleted the DotNetCore branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.