New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support context parameters on Before/After methods, FeatureContainer #779

Merged
merged 17 commits into from May 2, 2017

Conversation

Projects
None yet
3 participants
@gasparnagy
Collaborator

gasparnagy commented Feb 2, 2017

Fixes #552, #706

Scenario: Inject FeatureContext into a BeforeFeature hook
	Given the following hook
        """
	[BeforeFeature]
	public static void BeforeFeatureHook(FeatureContext featureContext)
	{
		if (featureContext == null)
			throw new ArgumentNullException("featureContext");
	}
        """
	When I execute the tests
	Then all tests should pass

prerequisite of #679

As part of the implementation I also had to introduce a new scope (container), the FeatureContainer, that is used to resolve Feature-level dependencies. It is "between" the test thread and the scenario container.

@gasparnagy gasparnagy requested review from SabotageAndi and samholder Feb 6, 2017

@SabotageAndi

This comment has been minimized.

Show comment
Hide comment
@SabotageAndi

SabotageAndi Feb 6, 2017

Collaborator

@gasparnagy FYI - It could take a while until I have time to review the PR.

Collaborator

SabotageAndi commented Feb 6, 2017

@gasparnagy FYI - It could take a while until I have time to review the PR.

@gasparnagy

This comment has been minimized.

Show comment
Hide comment
@gasparnagy

gasparnagy Feb 6, 2017

Collaborator

@SabotageAndi ok. let's see if @samholder can provide feedback. The concept you are anyway familiar with, right?

Collaborator

gasparnagy commented Feb 6, 2017

@SabotageAndi ok. let's see if @samholder can provide feedback. The concept you are anyway familiar with, right?

@gasparnagy

This comment has been minimized.

Show comment
Hide comment
@gasparnagy

gasparnagy Mar 16, 2017

Collaborator

@SabotageAndi @samholder I also would like to finalize this. Are you fine with the general concept?

Collaborator

gasparnagy commented Mar 16, 2017

@SabotageAndi @samholder I also would like to finalize this. Are you fine with the general concept?

@SabotageAndi

This comment has been minimized.

Show comment
Hide comment
@SabotageAndi

SabotageAndi Mar 16, 2017

Collaborator

I am fine with the general concept, but still had no time to look at the code.

Collaborator

SabotageAndi commented Mar 16, 2017

I am fine with the general concept, but still had no time to look at the code.

@samholder

Seems good to me.

Show outdated Hide outdated TechTalk.SpecFlow/Infrastructure/IBindingInstanceResolver.cs
public interface IBindingInstanceResolver
{
object ResolveBindingInstance(Type bindingType, IObjectContainer scenarioContainer);
object ResolveBindingInstance(Type bindingType, IObjectContainer scenarioContainer); //TODO: rename parameter to "container"

This comment has been minimized.

@samholder

samholder Mar 19, 2017

Contributor

do you want to fix this todo as part of this PR?

@samholder

samholder Mar 19, 2017

Contributor

do you want to fix this todo as part of this PR?

Show outdated Hide outdated TechTalk.SpecFlow/Infrastructure/IBindingInstanceResolver.cs
@@ -3,8 +3,26 @@
namespace TechTalk.SpecFlow.Infrastructure
{
//TODO: rename this to ITestObjectResolver

This comment has been minimized.

@samholder

samholder Mar 19, 2017

Contributor

do you want to fix this todo as part of this PR?

@samholder

samholder Mar 19, 2017

Contributor

do you want to fix this todo as part of this PR?

@samholder

This comment has been minimized.

Show comment
Hide comment
@samholder

samholder Mar 20, 2017

Contributor
Contributor

samholder commented Mar 20, 2017

@SabotageAndi

Finally had the time to look at it.
Didn't find anything.

Show outdated Hide outdated TechTalk.SpecFlow/Infrastructure/ContextManager.cs
@@ -25,14 +26,15 @@ public TContext Instance
get { return instance; }
}
public void Init(TContext newInstance)
public void Init(TContext newInstance, IDisposable newDisposable)

This comment has been minimized.

@SabotageAndi

SabotageAndi Apr 21, 2017

Collaborator

Is there a reason newDisposable is a IDisposable and not an IObjectContainer?

@SabotageAndi

SabotageAndi Apr 21, 2017

Collaborator

Is there a reason newDisposable is a IDisposable and not an IObjectContainer?

@SabotageAndi

This comment has been minimized.

Show comment
Hide comment
@SabotageAndi

SabotageAndi Apr 21, 2017

Collaborator

@gasparnagy Can I merge this for a 2.2 pre-release?

Collaborator

SabotageAndi commented Apr 21, 2017

@gasparnagy Can I merge this for a 2.2 pre-release?

@gasparnagy

This comment has been minimized.

Show comment
Hide comment
@gasparnagy

gasparnagy Apr 26, 2017

Collaborator

@SabotageAndi I make 2 small changes quickly.

Collaborator

gasparnagy commented Apr 26, 2017

@SabotageAndi I make 2 small changes quickly.

@gasparnagy gasparnagy changed the title from WIP: Support context parameters on Before/After methods to Support context parameters on Before/After methods, FeatureContainer Apr 26, 2017

@gasparnagy

This comment has been minimized.

Show comment
Hide comment
@gasparnagy

gasparnagy Apr 26, 2017

Collaborator

@SabotageAndi if the tests pass, you can merge it from my point of view.

Collaborator

gasparnagy commented Apr 26, 2017

@SabotageAndi if the tests pass, you can merge it from my point of view.

@SabotageAndi SabotageAndi merged commit 7098c83 into master May 2, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

Autom8edChaos added a commit to Autom8edChaos/SpecFlow that referenced this pull request Nov 6, 2017

Update from original (#1)
* update MSBuild.Community.Tasks to latest version via NuGet (#801)

* Regexless stepdef fixes (#786)

* Upgrade FluentAssertions

* Add simple unit test

* Add unit test for parametrized method

* Add unit tests for regexless - 36 failing

* fluent assertion does not allow { and } in the because part

* refine expectations: shortening like "doesn't" should not work automatically

* fix regexless matching issues

* a bit more optimal solution that produces simpler regexes

* Improve param locator

* should not remove keywords from binding culture

* small code improvements

* refine expectations: should not allow whitespace or punctuation in the front of the step text (Given !foo) in order to make the generated regex faster (does not start with rule)

* small refactor

* update changelog, remove wip tags

* add test for issue #715

* Update changelog showing that #301 is also fixed

* add CI NuGet package feed

* Added support for MsTest's [DeploymentItem] attribute with @mstest:DeploymentItem tag (#805)

* Added support for MsTest's [DeploymentItem] attribute with @deploy tag (Issue #803)
* Prefixing new tag with `MsTest:`
* using pascal case @mstest:DeploymentItem
* wrapping nested using blocks with curly brackets

* Change project reader from MSBuild to XML (#837)

* improve tests for project reader
* add tests for new csproj format
* change variable naming
* complete read of classic projects
* refactoring
* mark not used properties as obsolete
* support new project system & refactorings
* use AppDomainIsolatedTask instead of Task to solve file looking issues with MsBuild
* fix typo :-/
* add tests for linked files

* Added display name for theory attribution (#812)

* Added display name for theory attribution
* Fixed incorrect namespace reference to TheoryAttribute (no longer part of extensions)

* Support context parameters on Before/After methods, FeatureContainer (#779)

* Added scenario: Inject FeatureContext into a BeforeFeature hook
* first dummy implementation to make the scenario pass (runtime tests failing)
* Use bindingInstanceResolver to resolve parameters
* make unit tests pass
* Add unit tests for what we have so far
* support for resolving hook parameters from scenario context
* better then step for the scenarios
* fix unit test error
* added failing test for resolving objects from feature container
* refactor ScenarioContext
* Implement FeatureContainer
* move binding culture initialization to FeatureContext
* fix featurecontext resolution from scenario container
* Refactor scenario and feature context and remove displose hack that was necessary to avoid circular disposing loops
* fix unit test failure
* Make InternalContextManager to IObjectContainer reference more explicit
* rename IBindingInstanceResolver to ITestObjectResolver (breaking change for some plugins)

* Wildcard support for project reader (#843)

* Wildcard support for project reader
* fix tests for AppVeyor

* update changelog

* Config file refactoring & Json Config file support (#690)

* split app.config elements to multiple files

* make RuntimeConfiguration nearly immutable

* extract config loading logic to RuntimeConfigurationLoader

* reformating

* add tests for app.config reading

* move ConfigurationTest to separate Namespace

* rename file

* add json tests

* add json.net dependency

* json config file parsing

* add tests for checking which config file is used

* refactoring for tests and added tests

* remove GeneratorConfiguration

* fix dependencies for generator

* fix tests

* fix tests

* move files & fix namespaces

* work on generation config loading

* fix tests and make parsing more robust

* fix and comment test

* small cleanups

* remove ToolLanguage, GeneratorPath and DetectAmbiguousMatches from Config

rename PrintConfigSource to TraceConfigSource

* fix merge issues

* remove file

* add missing json handling

* update changelog

* add Newtonsoft.Json dependency to the NuGet package

* update TestGenerator version

* fix typo in README.md (#853)

* fix VS code behind generation (#855)

* fix redirects
* fix serialization problem with Visual Studio
* fix lineending

* Order sensitive overload for compare to set (#778)

* Add tests
* Refactor TableDifferenceResults to be able to represent order sensitive diff
* make throw tests pass
* refactor message tests to be able to test order sensitive comparison
* fix diff messages for order sensitive
* Replace Tuple with TableDifferenceItem

* Hook with multiple Tags scoped are executed more than once (#848)

* add failing tests
* Fix for #848 Hook with multiple Tags scoped are executed more than once

* making sure that the ordering is preserved (the GroupBy might change the order)

* update changelog for 2.2.0-prerelease20170523

* add GitExtensions configuration file with github and appveyor configuration (#862)

* Added TestThreadContext and exposed it in ContextManager and Steps base class (#875)

* Added TestThreadContext and exposed it in ContextManager and Steps base class

* Upgrade to BoDi v1.3 (#876)

* fix shadow copy test issue
* upgrade BoDi to v1.3
* remove unnecessary BoDi workarounds

* Adds support for xUnit2 ITestOutputHelper #575 (#874)

* Resolves #575 

* added tests for adding support for xUnit2 ITestOutputHelper class

added XUnit2Generator unit tests
added XUnit2Provider specs
updated XUnitExecutionDriver to output results in default (xUnit) xml
output instead of NUnit xml format

* swapped the order of the TestInitialize call and the setting of the _testOutputHelper field

* expose TestAssembly and BindingAssemblies on ITestRunnerManager

* Fix generation from visual studio (#877)

* rename field so that it matches the version of this class from 1.9 (which is used by VS)
* make AppConfig the default value
* add warnings

* Update for 2.2 release

* use FileStream constructor which grants ReadWrite to other processes. (#906)

use FileStream constructor which grants ReadWrite to other processes

techtalk#904

* Added changelog entry for PR (#907)

* correct version number

* Access MSTest's TestContext property via ScenarioContext (#882)

* injected MSTest's TestContext into ScenarioContext

* fixed TestContext property generation for VB.Net

* @MSBuild [DeploymentItem] - added option to provide output directory (#901)

* @MSBuild [DeploymentItem] - added option to provide output directory

* code review

* update changelog after merging PRs #882 & #901

* add tests for Feature/Scenario Hooks with context parameters (#925)

* Issue Template (#924)

* Create issue template

* add SpecFlow+Runner to test runners

* Rename issue to ISSUE_TEMPLATE.md

* Allowed custom XSLT scripts to contain scripts.

* Updated changelog for new addition

* enter release date

* fix changelog after 2.2.1 release

* added link to Stack Overflow repro topic (#942)

* Avoid trying to load empty configuration

* Set ConfigSource of default holder to "Default" instead of "AppConfig"

* Turn off line ending git auto conversion (#953)

* Stop git from automatically converting line endings everytime repo is cloned
* add .vs folder to .gitignore

* Fixing copy link in step definition report (#958)

* Update changelog

* Support for tuples (#951)

* Initial support for Tuples
* Adding nuspec dependency
* Added tupple error when there are too many properties

* add entry for tuple

* Make scenario TestResult public (#963)

* Make scenario TestResult public

* - Rename to ScenarioExecutionStatus
- Moved this to the root of the project
- UndefinedStep in enum
- Edited changelog.txt

* Update changelog.txt

* Single agent for unit tests execution

* Fix incorrect appveyour config

* Try to change test_script to test

* Disable automatic tests

* Provide full path to test assemblies

* Expose configuration var to batch

* Hardcoded configuration as Release

* Use %% accessor for configuration var

* Add hyperlink to discussion group (#965)

Remove ambiguity regarding where to go for questions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment