Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Fixed/custom name on taken pictures #90

Closed
harniher opened this issue Apr 5, 2019 · 6 comments
Closed

Fixed/custom name on taken pictures #90

harniher opened this issue Apr 5, 2019 · 6 comments
Assignees
Milestone

Comments

@harniher
Copy link

harniher commented Apr 5, 2019

If you could have the ability to give the pictures a custom name will be great and useful, also if no name is given, the API saves the photo like the current version does (date/time format).
Thank you

@techyian techyian self-assigned this Apr 5, 2019
@techyian techyian added this to the v0.6 milestone Apr 5, 2019
@techyian
Copy link
Owner

techyian commented Apr 5, 2019

Thanks, will try and get this into the v0.5.1 release.

@harniher
Copy link
Author

harniher commented Apr 5, 2019 via email

@techyian
Copy link
Owner

techyian commented Apr 7, 2019

Hi @harniher, this work is now in the dev branch if you want to build from source. I have added an additional constructor to the FileStreamCaptureHandler class which takes a single string for the full file path. All subclasses of FileStreamCaptureHandler also implement this new constructor.

Let me know if you run into any issues with it. A new release will be done soon with this work in.

@techyian techyian closed this as completed Apr 8, 2019
@harniher
Copy link
Author

harniher commented Apr 8, 2019

Hi @techyian ,
I've tested the code and it works like charm just one little bug that doesn´t affect the performance of the API, when it takes the photo the xterminal shows this

Preparing to take picture. Resolution: 0 x 0. Encoder: JPEG. Pixel Format: I420.

before the update it showed the actual resolution of the picture taken, the picture saved is of the defined resolution (640x480 in this case), just wanted to let you know this bug.
Thanks for the prompt response/update

@techyian
Copy link
Owner

techyian commented Apr 8, 2019

Thanks for letting me know :) I'll look into that, it'll have regressed from the work done for #88. Glad to hear it's working for you.

@techyian
Copy link
Owner

techyian commented Apr 8, 2019

Just pushed a fix for this so should hopefully be ok now. It was getting the resolution from the Image Encoder which doesn't have a width/height stored and so was just outputting 0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants