Permalink
Show file tree
Hide file tree
8 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Fix for security vulnerability: Using the phar:// wrapper it was poss…
…ible to trigger the unserialization of user provided data.
- Loading branch information
1 parent
b32e75e
commit 1861e33
Showing
6 changed files
with
49 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1861e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this change is wrong.
file_exists()is not the only method vulnerable for this kind of attack. It is also thegetimagesize()call in line 6856, which can now be exploited again due to your deletions of lines 6848 to 6856 (my fix from #94).1861e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have fixed this in 6.2.22.
Thanks for reporting this.
1861e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nicolaasuni. Version 6.2.22 prevents the attack again.👍
1861e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CVE-2018-17057 was assigned to this issue.
1861e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created FriendsOfPHP/security-advisories#327 to update https://security.symfony.com
1861e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change broke my phar. O.O
If I pack my project into a phar then TCPDF respond "Could not include font definition file: helvetica.", otherwise work fine. So, what is the right way for pack into a phar the TCPDF now?
1861e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello i use 6.2.0 version and used scanner and it shows affected as well is there a exploit it ?
1861e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonzom any day there is a security issue revealed you should assume there was a high likelihood that some bad actor already discovered it before. And after the issue and fix had been revealed then it is pretty much a certainty that there are exploits available. You should really update.