Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup handling of unicode filenames #165

Merged
merged 9 commits into from Sep 25, 2018

Conversation

@Mrmaxmeier
Copy link
Contributor

Mrmaxmeier commented Feb 28, 2018

This simplifies the name_of_file variable by keeping it utf8-encoded instead of converting to utf16.
Previously filenames with low non-ascii characters like ö be wrongly processed while characters outside of the BMP range that require two utf16 code-points (like emojis) would cause segfaults.

With this patch tectonic now happily writes to hallöchen 🐨 welt 🌍.pdf instead of crashing.

@pkgw

This comment has been minimized.

Copy link
Collaborator

pkgw commented Sep 16, 2018

I'm sorry, I have no idea why I never followed up this PR. I will see if I can rebase it onto the current master.

@Mrmaxmeier Mrmaxmeier force-pushed the Mrmaxmeier:cleanup-unicode branch from 10ecf4d to 4ea5dab Sep 20, 2018
@pkgw pkgw self-assigned this Sep 20, 2018
@pkgw

This comment has been minimized.

Copy link
Collaborator

pkgw commented Sep 25, 2018

This is awesome! Thanks for a great contribution.

@pkgw pkgw merged commit b53f3b9 into tectonic-typesetting:master Sep 25, 2018
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mrmaxmeier Mrmaxmeier deleted the Mrmaxmeier:cleanup-unicode branch Jun 20, 2019
Mrmaxmeier pushed a commit to Mrmaxmeier/tectonic that referenced this pull request Oct 28, 2019
fix gid while
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.