Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More work towards HTML output #239

Merged
merged 11 commits into from Oct 9, 2018
Merged

More work towards HTML output #239

merged 11 commits into from Oct 9, 2018

Conversation

@pkgw
Copy link
Collaborator

pkgw commented Oct 7, 2018

Which, in practice, means tedious analysis of the line_break() function, because I am (slowly) working towards giving it a mode where it basically doesn't do any linebreaking.

I've added a few tests that should hopefully juice the coverage; they at least do add some coverage within line_break().

pkgw added 9 commits Oct 7, 2018
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #239 into master will increase coverage by 1.63%.
The diff coverage is 77.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   38.24%   39.87%   +1.63%     
==========================================
  Files         133      133              
  Lines       63695    63742      +47     
==========================================
+ Hits        24359    25419    +1060     
+ Misses      39336    38323    -1013
Impacted Files Coverage Δ
tectonic/xetex-xetexd.h 57.14% <ø> (ø) ⬆️
tectonic/dpx-pdfdev.c 40.15% <0%> (ø) ⬆️
tectonic/xetex-ini.c 86.96% <0%> (ø) ⬆️
tectonic/dpx-cmap_read.c 0% <0%> (ø) ⬆️
tectonic/dpx-cmap_write.c 0% <0%> (ø) ⬆️
tectonic/dpx-pkfont.c 0.62% <0%> (ø) ⬆️
tectonic/dpx-t1_load.c 70.83% <100%> (ø) ⬆️
tests/tex-outputs.rs 96.22% <100%> (+0.22%) ⬆️
tectonic/xetex-xetex0.c 77.31% <62.5%> (+2.15%) ⬆️
tectonic/xetex-synctex.c 67.42% <66.66%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62565e...0bc95c9. Read the comment docs.

@pkgw pkgw force-pushed the pkgw:html-work branch from ed97b84 to cf49f0a Oct 8, 2018
Older MSVC compilers don't like %z; add some #define logic to make things
portable.
@pkgw pkgw force-pushed the pkgw:html-work branch 6 times, most recently from 29686db to cdc358b Oct 8, 2018
For some reason this test is now giving problems on AppVeyor ... but not when
I build Tectonic myself. Everything else works and this test isn't "special",
so just disable it for expediency. Bug #244 filed to track this hack, though.
@pkgw pkgw force-pushed the pkgw:html-work branch from cdc358b to 0bc95c9 Oct 9, 2018
@pkgw pkgw merged commit e469ff3 into tectonic-typesetting:master Oct 9, 2018
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 77.03% of diff hit (target 38.24%)
Details
codecov/project 39.87% (+1.63%) compared to c62565e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pkgw pkgw deleted the pkgw:html-work branch Oct 9, 2018
Mrmaxmeier pushed a commit to Mrmaxmeier/tectonic that referenced this pull request Dec 13, 2019
Merge xetex_layout_engine and xetex_layout_interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.