From 5609cae1cfe795f2ae3c86c114356602e83c5d15 Mon Sep 17 00:00:00 2001 From: Teddy Gustiaux Date: Mon, 29 Apr 2019 21:12:22 -0400 Subject: [PATCH] fix: new separator always added to default location (close #44) --- src/background/bookmarking/BuiltinBookmarking.js | 1 + src/background/utils/Utils.js | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/src/background/bookmarking/BuiltinBookmarking.js b/src/background/bookmarking/BuiltinBookmarking.js index 6f4a298..f192543 100644 --- a/src/background/bookmarking/BuiltinBookmarking.js +++ b/src/background/bookmarking/BuiltinBookmarking.js @@ -72,6 +72,7 @@ class BuiltinBookmarking { async move(id, bookmarkInfo) { if (!this._isSystemCreated(bookmarkInfo)) return; + if (Utils.bookmarkIsSeparator(bookmarkInfo)) return; let bookmarkTreeNode; if (Utils.bookmarkIsWebPage(bookmarkInfo)) { bookmarkTreeNode = this._createMovingPropertiesForBookmark(); diff --git a/src/background/utils/Utils.js b/src/background/utils/Utils.js index 1256e66..12265ac 100644 --- a/src/background/utils/Utils.js +++ b/src/background/utils/Utils.js @@ -64,6 +64,18 @@ class Utils { // BOOKMARKS // ------------------------------------------------------------------------------------------------- + // Indicate if a bookmark object is a separator + static bookmarkIsSeparator(bookmarkInfo) { + let isSeparator = false; + if ( + Object.prototype.hasOwnProperty.call(bookmarkInfo, 'type') && + bookmarkInfo.type === 'separator' + ) { + isSeparator = true; + } + return isSeparator; + } + // Indicate if a bookmark object is a web page static bookmarkIsWebPage(bookmarkInfo) { let isWebPage = false;