More performance tweaks #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son via isset($hashset[$char])
|
Once the PR is ready to merge please tag me and I'll take a look. Thanks for the contributions! |
|
All tests are passed. |
|
@tedivm PR is ready to merge |
tedivm
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've tried to go deeper into performance tweaks.
Please review series of changes which I've prepared.
I've bench-marked every improvement separately before deciding whether to add it.
As a test I've run new and old version on JS library for 3D rendering (threejs-lib) which consists of 352 JavaScript files, 11MB.
I compared MD5 of minified content for new and current-master versions of JShink - no changes found.
Current master:
real 0m10,164s
user 0m10,118s
sys 0m0,036s
New version:
real 0m9,469s
user 0m9,454s
sys 0m0,008s
New version is 0.695 sec faster, 6.8% improvement (on this specific JS lib).
IMO not bad :-)
Andrey.