Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Reworking of Filesystem handler #57

Merged
merged 2 commits into from Feb 26, 2013

Conversation

Projects
None yet
2 participants
Owner

tedivm commented Dec 28, 2012

This is a reworking of the filesystem handler to make some of the code more clear, primarily in an attempt to deal with bugs like that in issue #54.

@tedivm tedivm Rewrote Filesystem->getDataFromFile file for clarity
Reworked the code to make it clearer, and expanded on comments.
f4464ca
Contributor

Baachi commented Jan 21, 2013

Why not simply create a cachefile like this:

return array('data' => 'some-data', 'expire' => 5787545);

And include it in the adapter class:

$data = require_once $cachePath.'/somecacheid.cache';
Owner

tedivm commented Jan 22, 2013

@Baachi, that's essentially what I do, although for performance and other resource I just directly assign the variables and include them, rather than returning values. I'm not sure if there would be any benefit to changing it (but could be missing something).

@tedivm tedivm added a commit that referenced this pull request Feb 26, 2013

@tedivm tedivm Merge pull request #57 from tedivm/data_bug
Reworking of Filesystem handler
677de25

@tedivm tedivm merged commit 677de25 into master Feb 26, 2013

1 check passed

default The Travis build passed
Details

@tedivm tedivm deleted the data_bug branch Feb 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment